Bump tenacity to 6.2 #11313
Merged
Bump tenacity to 6.2 #11313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Oct 6, 2020
Member
|
@kaxil -> I would like to check if this works - do not merge it please before I take a look. I have a feeling we have some problem with upgrading constraints and I would like to have closer look tomorrow on it. |
potiuk
requested changes
Oct 6, 2020
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Just want to take a look at this before it gets merged.
Member
|
why did we limit it in the first place? something must have broken with 5.2? |
Member
|
I think @kaxil wants to update constraints. But I am afraid it will not work this way. I will take a look at this thing tomorrow. |
Member
Author
Member
Author
Member
Author
|
Just to be clear, I want to update requirements not just constraints. Constraints is the by-product. I am familiar with the current CI problem regarding constraints. |
ashb
approved these changes
Oct 6, 2020
potiuk
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to limit tenacity. One of my upcoming PRs (or a commit in scheduler-ha PR) will use a new feature available in the newer version.
One of the reasons for creating a separate PR for this is so that constraints are updated and when I create new PR (or merge to scheduler-ha PR) it will run against a newer version of tenacity because of the upgraded constraints, without it, it will error.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.