[Doc] Correct description for macro task_instance_key_str #11062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Sep 21, 2020
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
Correction based on code https://github.com/apache/airflow/blob/master/airflow/models/taskinstance.py (cherry picked from commit 2afb20d)
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
Correction based on code https://github.com/apache/airflow/blob/master/airflow/models/taskinstance.py (cherry picked from commit 2afb20d)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Correction based on code https://github.com/apache/airflow/blob/master/airflow/models/taskinstance.py (cherry picked from commit 2afb20d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of macro variable
task_instance_key_strstates its format is{dag_id}_{task_id}_{ds}, but it's actually{dag_id}__{task_id}__{ds_nodash}.Related codes:
https://github.com/apache/airflow/blob/master/airflow/models/taskinstance.py#L1474-L1475
This can be easily reproduced by task “runme_0” in the example DAG “example_bash_operator”.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.