Add ImportChangesRule for upgrade check #11056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
added
the
area:upgrade
turbaszek
force-pushed
the
add-changed-import-rule
branch
from
429983a to
24ccf6a
Compare
turbaszek
force-pushed
the
add-changed-import-rule
branch
from
24ccf6a to
f46c039
Compare
Member
Author
|
cc @vikramkoka |
This comment has been minimized.
This comment has been minimized.
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
turbaszek
force-pushed
the
add-changed-import-rule
branch
from
f46c039 to
4d48116
Compare
Member
Author
|
The docs faliure was already fixed. |
Member
Author
kaxil
reviewed
Sep 24, 2020
Comment on lines
+28
to
+33
| class ImportChange( | ||
| NamedTuple( | ||
| "ImportChange", | ||
| [("old_path", str), ("new_path", str), ("providers_package", Optional[None])], | ||
| ) | ||
| ): |
Member
There was a problem hiding this comment.
can be simplified
Suggested change
| class ImportChange( | |
| NamedTuple( | |
| "ImportChange", | |
| [("old_path", str), ("new_path", str), ("providers_package", Optional[None])], | |
| ) | |
| ): | |
| class ImportChange(NamedTuple) | |
| old_path: str | |
| new_path: str | |
| providers_package: Optional[None] | |
Member
There was a problem hiding this comment.
oh wait, I know why you did this, for compatibility with Py 2.7 , Py 3.5 ?
Member
Author
There was a problem hiding this comment.
Yup, not a big fan of this but we this command has to work with 2.7
There was a problem hiding this comment.
Some operators did the other way.. from providers to core
#10013
this message will be wrong for it?
Member
Author
There was a problem hiding this comment.
The message will be:
Using
airflow.operators.email_operator.EmailOperatorwill be replaced byairflow.operators.email.EmailOperator.
And I see no place for confusion here
kaxil
approved these changes
Sep 24, 2020
TobKed
approved these changes
Sep 25, 2020
potiuk
force-pushed
the
v1-10-test
branch
2 times, most recently
from
bd4214b to
195f00d
Compare
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new rule that will be run during airflow upgrade-check
and will look for old clasess and imports incompatible with
Airflow 2.0.
Example:
Related to #8765
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.