Add CeleryKubernetesExecutor #10901
Merged
Add CeleryKubernetesExecutor #10901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:docs
area:Scheduler
turbaszek
approved these changes
Sep 12, 2020
Member
turbaszek
left a comment
turbaszek
left a comment
There was a problem hiding this comment.
I'm ok with merging the current scope of this PR. The ideas from #10654 (comment) can be implemented in follow up PR. @dimberman what do you think?
turbaszek
approved these changes
Sep 13, 2020
turbaszek
reviewed
Sep 13, 2020
turbaszek
reviewed
Sep 13, 2020
turbaszek
reviewed
Sep 13, 2020
potiuk
approved these changes
Sep 14, 2020
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice. Few nits about the docs where I agree with @turbaszek's proposals
it consists of CeleryExecutor and KubernetesExecutor, which allows users to route their tasks to either Kubernetes or Celery based on the queue defined on a task
Contributor
Author
|
thanks @turbaszek and @potiuk for the suggestions and making the docs better. |
turbaszek
approved these changes
Sep 15, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it consists of CeleryExecutor and KubernetesExecutor, which allows users
to route their tasks to either Kubernetes or Celery based on the queue
defined on a task
(I re-forked the apache/airflow repo, mine was the incubator-airflow)
Orignal PR is: #10654
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.