Skip to content

Fix failing static check: Ignore MyPy type #10879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kaxil wants to merge 1 commit into from
Closed

Fix failing static check: Ignore MyPy type #10879

kaxil wants to merge 1 commit into from

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Sep 11, 2020 •
edited
Loading

Static check if failing on Master with the following error:

Running: pre-commit run mypy --show-diff-on-failure -a

Run mypy.................................................................Failed
- hook id: mypy
- exit code: 1

airflow/models/dagrun.py:72: error: Cannot determine type of 'dag_id'
            primaryjoin=and_(TI.dag_id == dag_id, TI.execution_date == exe...
                             ^
airflow/models/dagrun.py:72: error: Cannot determine type of 'execution_date'
            primaryjoin=and_(TI.dag_id == dag_id, TI.execution_date == exe...
                                                  ^
Found 2 errors in 1 file (checked 2406 source files)

This PR ignores the line that is causing the error

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil
Copy link
Member Author

kaxil commented Sep 11, 2020

@potiuk should I just close this PR ?

@potiuk potiuk closed this Sep 11, 2020
@kaxil kaxil deleted the ignore-type-mypy branch September 11, 2020 17:34
@potiuk potiuk mentioned this pull request Sep 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil @potiuk