Remove unused type comment that upsets mypy #10877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something slightly odd is happening here. In apache#10729 it passed the mypy tests with this in place, but now if I make a change to this file (or to scheduler_job.py, which imports DagRun) I get an error _with_ this.
kaxil
approved these changes
Sep 11, 2020
potiuk
approved these changes
Sep 11, 2020
Member
Author
|
@kaxil you probably shouldn't have merged this, since it's failing static checks. |
Member
Author
|
Something odd is going on with this line -- sometimes it complains about unused type comment, other times it complains about "determine type of ..." Maybe I need to put the type ignore comments in the parenthesis. |
Member
Author
|
And yet, on the result of this PR being merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something slightly odd is happening here.
In #10729 it passed the mypy tests with this in place, but now if I make
a change to this file (or to scheduler_job.py, which imports DagRun) I
get an error with this.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.