Log task_instance execution duration as milliseconds #10632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
potiuk
reviewed
Aug 28, 2020
mjpieters
force-pushed
the
timer_milliseconds/master
branch
from
d1112fa to
a5d258b
Compare
ashb
approved these changes
Oct 21, 2020
Member
|
Hmmm all the K8s tests failing is a worrying sign. Could you rebase and see if that fixes it? |
mjpieters
force-pushed
the
timer_milliseconds/master
branch
from
a5d258b to
6bcf383
Compare
Contributor
Author
Rebased, and the only failure looks unrelated and flakey to me. |
mjpieters
force-pushed
the
timer_milliseconds/master
branch
from
6bcf383 to
8c60dd4
Compare
This is best achieved by passing a `timedelta()` to `Stats.timing()`, and leave worrying about time units to that method.
mjpieters
force-pushed
the
timer_milliseconds/master
branch
from
8c60dd4 to
04e6a0e
Compare
Contributor
Author
|
I don't think the RabbitMQ and OpenLDAP Kerberos services failure to start have anything to do with this PR. |
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
This is best achieved by passing a `timedelta()` to `Stats.timing()`, and leave worrying about time units to that method.
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
This is best achieved by passing a `timedelta()` to `Stats.timing()`, and leave worrying about time units to that method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best achieved by passing a
timedelta()toStats.timing(), and leave worrying about time units to that method.This is my fix for #10629, for the master branch. A separate pull request will be made for the v1-10 branch.