-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Kerberos Auth for Presto #10488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kerberos Auth for Presto #10488
Conversation
b0ea96c to
49335b2
Compare
17e8383 to
2b9c7c7
Compare
08da06e to
193b146
Compare
|
Great change ! Love the way you implemented Dev images - that's exactly how we can improve our dev docker images used for Development, |
193b146 to
8002ba2
Compare
|
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
|
The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
|
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change requested - we need to pre-build the image and place it in airflow dockerhub to optimise speed of the tests.
c6af5a0 to
de84bf2
Compare
Close: #10306
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
ClIn case of backwards incompatible changes please leave a note in UPDATING.md.