Skip to content

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Aug 23, 2020

Close: #10306


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
ClIn case of backwards incompatible changes please leave a note in UPDATING.md.

@mik-laj mik-laj changed the title Add Kerberos Auth for Presto [WIP] Add Kerberos Auth for Presto Aug 23, 2020
@mik-laj mik-laj force-pushed the kerberos-presto-2 branch 2 times, most recently from b0ea96c to 49335b2 Compare August 24, 2020 03:52
@mik-laj mik-laj force-pushed the kerberos-presto-2 branch from 17e8383 to 2b9c7c7 Compare August 25, 2020 06:02
@mik-laj mik-laj requested a review from potiuk August 25, 2020 09:32
@mik-laj mik-laj changed the title [WIP] Add Kerberos Auth for Presto Add Kerberos Auth for Presto Aug 25, 2020
@mik-laj mik-laj force-pushed the kerberos-presto-2 branch from 08da06e to 193b146 Compare August 26, 2020 01:15
@mik-laj
Copy link
Member Author

mik-laj commented Aug 26, 2020

@jaketf @potiuk It is ready to be reviewed if you could find the time.

@potiuk
Copy link
Member

potiuk commented Aug 27, 2020

Great change ! Love the way you implemented Dev images - that's exactly how we can improve our dev docker images used for Development,

@mik-laj mik-laj changed the title Add Kerberos Auth for Presto [WIP] Add Kerberos Auth for Presto Aug 27, 2020
@mik-laj mik-laj changed the title [WIP] Add Kerberos Auth for Presto Add Kerberos Auth for Presto Sep 17, 2020
@mik-laj mik-laj force-pushed the kerberos-presto-2 branch from 193b146 to 8002ba2 Compare October 5, 2020 07:53
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).

You can checks the status of those images in The workflow run

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested - we need to pre-build the image and place it in airflow dockerhub to optimise speed of the tests.

@mik-laj mik-laj merged commit 1543923 into apache:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Kerberos Support for Presto Hook

3 participants