Mounting from sources is disabled for tests #10472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2020
potiuk
force-pushed
the
switches-back-not-mounting-sources-for-tests
branch
2 times, most recently
from
4e0aac8 to
09c62a3
Compare
potiuk
force-pushed
the
switches-back-not-mounting-sources-for-tests
branch
2 times, most recently
from
90cc8fb to
b7c24c9
Compare
potiuk
force-pushed
the
switches-back-not-mounting-sources-for-tests
branch
from
b7c24c9 to
ae41168
Compare
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the apache#10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the apache#10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue apache#10471 discusses this in detail.
potiuk
force-pushed
the
switches-back-not-mounting-sources-for-tests
branch
from
ae41168 to
dca364a
Compare
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Aug 23, 2020
Requires apache#10470 and apache#10472
Member
Author
|
@turbaszek -> that one fixes #10445 failure you experienced. We should merge it so others won't have similar problems. |
turbaszek
approved these changes
Aug 24, 2020
mik-laj
approved these changes
Aug 24, 2020
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2020
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the apache#10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the apache#10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue apache#10471 discusses this in detail. (cherry picked from commit 4fa7df5)
potiuk
added a commit
that referenced
this pull request
Sep 15, 2020
potiuk
added a commit
that referenced
this pull request
Sep 15, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the #10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the #10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue #10471 discusses this in detail. (cherry picked from commit 4fa7df5)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the apache#10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the apache#10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue apache#10471 discusses this in detail. (cherry picked from commit 4fa7df5)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the #10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the #10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue #10471 discusses this in detail. (cherry picked from commit 4fa7df5)
potiuk
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the #10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the #10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue #10471 discusses this in detail. (cherry picked from commit 4fa7df5)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the apache#10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the apache#10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue apache#10471 discusses this in detail. (cherry picked from commit 4fa7df5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to enable mounting from sources for a short while
because we had to find a way to add new scripts to the
"workflow_run" workflow we have. This also requires
the #10470 to be merged - perf_kit to be moved to tests.utils because
it was in a separate directory and image without mounting sources
could not run the tests.
It also partially addresses the #10445 problem where
there was difference between sources in the image and coming
from the master. This comes from GitHub running merge on
non-conflicting changes in the PR and something that will
be addressed shortly.
The issue #10471 discusses this in detail.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.