Move perf_kit to tests.utils #10470
Merged
Move perf_kit to tests.utils #10470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
move-perfkit-to-tests
branch
from
d42fe32 to
58c768f
Compare
potiuk
force-pushed
the
move-perfkit-to-tests
branch
from
58c768f to
3bb979f
Compare
Member
Author
|
@mik-laj - I totally don't understand why those tests fail with 2 rather than expected number of runs: Those tests are randomly failing also for older runs but here it is consistent once I moved the code to test/utils. Can you please take a look and see what could be wrong here/? It's rather difficult to figure out, but at least this is consistent now and we might have a chance to fix it permanently and remove the flakiness. |
Member
Author
|
OK. I think I know @mik-laj let me try smth next |
potiuk
force-pushed
the
move-perfkit-to-tests
branch
from
3bb979f to
2e2e92b
Compare
Member
Author
|
Yeah. I think I found it :) |
Member
Author
|
yeah, I found it :). I also had to move the perf dag path |
Perf_kit was a separate folder and it was a problem when we tried to build it from Docker-embedded sources, because there was a hidden, implicit dependency between tests (conftest) and perf. Perf_kit is now moved to tests to be avaiilable in the CI image also when we run tests without the sources mounted. This is changing back in apache#10441 and we need to move perf_kit for it to work.
potiuk
force-pushed
the
move-perfkit-to-tests
branch
from
2e2e92b to
a507414
Compare
Member
Author
|
@turbaszek - because both dirs were there and my eye caught "utils" first I guess :) Both directories were there when I moved it, so I guess arbitrarily I chose the "utils" one. But feel free to merge those two. There is no difference from the build POV. |
Member
|
The point is that |
Member
Author
I see, not too obvious though :( . I was never suspecting this. But I am not sure how to make it more obvious, |
Member
I think we should pay more attention to this in future. At least I will do 😄
|
Member
Author
|
🤣 |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2020
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the apache#10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the apache#10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue apache#10471 discusses this in detail. (cherry picked from commit 4fa7df5)
potiuk
added a commit
that referenced
this pull request
Sep 15, 2020
potiuk
added a commit
that referenced
this pull request
Sep 15, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the #10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the #10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue #10471 discusses this in detail. (cherry picked from commit 4fa7df5)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the apache#10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the apache#10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue apache#10471 discusses this in detail. (cherry picked from commit 4fa7df5)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the #10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the #10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue #10471 discusses this in detail. (cherry picked from commit 4fa7df5)
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the #10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the #10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue #10471 discusses this in detail. (cherry picked from commit 4fa7df5)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
We had to enable mounting from sources for a short while because we had to find a way to add new scripts to the "workflow_run" workflow we have. This also requires the apache#10470 to be merged - perf_kit to be moved to tests.utils because it was in a separate directory and image without mounting sources could not run the tests. It also partially addresses the apache#10445 problem where there was difference between sources in the image and coming from the master. This comes from GitHub running merge on non-conflicting changes in the PR and something that will be addressed shortly. The issue apache#10471 discusses this in detail. (cherry picked from commit 4fa7df5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perf_kit was a separate folder and it was a problem when we tried to
build it from Docker-embedded sources, because there was a hidden,
implicit dependency between tests (conftest) and perf.
Perf_kit is now moved to tests to be avaiilable in the CI image
also when we run tests without the sources mounted.
This is changing back in #10441 and we need to move perf_kit
for it to work.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.