Fix docs build uploading artifacts #10441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-docs-upload
branch
from
97a5099 to
2920789
Compare
Member
|
Github Action are sad. |
Member
Author
Yeah - it needs #10442 to be merged. |
potiuk
force-pushed
the
fix-docs-upload
branch
2 times, most recently
from
93f21f7 to
3070250
Compare
potiuk
commented
Aug 21, 2020
potiuk
force-pushed
the
fix-docs-upload
branch
2 times, most recently
from
22bb287 to
0d36cc4
Compare
potiuk
force-pushed
the
fix-docs-upload
branch
2 times, most recently
from
91a2661 to
57fe261
Compare
Member
Author
|
@mik-laj -> I split out moving perf_kit to separate commit. |
potiuk
force-pushed
the
fix-docs-upload
branch
from
57fe261 to
fac68e4
Compare
potiuk
force-pushed
the
fix-docs-upload
branch
from
fac68e4 to
56e256e
Compare
potiuk
force-pushed
the
fix-docs-upload
branch
3 times, most recently
from
3faa9d5 to
fab3691
Compare
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Aug 22, 2020
Perf_kit was a separate folder and it was a problem when we tried to build it from Docker-embedded sources, because there was a hidden, implicit dependency between tests (conftest) and perf. Perf_kit is now moved to tests to be avaiilable in the CI image also when we run tests without the sources mounted. This is changing back in apache#10441 and we need to move perf_kit for it to work.
potiuk
force-pushed
the
fix-docs-upload
branch
from
fab3691 to
30142c0
Compare
potiuk
added a commit
that referenced
this pull request
Aug 22, 2020
Perf_kit was a separate folder and it was a problem when we tried to build it from Docker-embedded sources, because there was a hidden, implicit dependency between tests (conftest) and perf. Perf_kit is now moved to tests to be avaiilable in the CI image also when we run tests without the sources mounted. This is changing back in #10441 and we need to move perf_kit for it to work.
potiuk
force-pushed
the
fix-docs-upload
branch
from
30142c0 to
a893035
Compare
Requires apache#10470 and apache#10472
potiuk
force-pushed
the
fix-docs-upload
branch
from
a893035 to
ab3b800
Compare
turbaszek
approved these changes
Aug 24, 2020
mik-laj
reviewed
Aug 24, 2020
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2020
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
potiuk
added a commit
that referenced
this pull request
Sep 15, 2020
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
potiuk
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Requires apache#10470 and apache#10472 (cherry picked from commit 946c9de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than callig the python build we should call the bash
script which not only builds the docs but also copies them
to the /files dir so that they can be uploaded by the artifact
uploader
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.