When precommits are run, output is silenced #10390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
silence-output-of-ci-builds
branch
from
4affc3c to
f6ece9a
Compare
potiuk
force-pushed
the
silence-output-of-ci-builds
branch
from
f6ece9a to
cc8e290
Compare
Member
Author
|
@mik-laj -> this one nicely fixes the output of pre-commits locally and GitHub actions so that no extra stuff is visible. Still it keeps pre-commit spinner /progress running as well as handles well VERBOSE flag. And I switched to using aliases for docker/kubectl everywhere where I can (aliases do not work in pre-commits as they are not interactive) Of course erors are printed on pre-commit :) |
potiuk
force-pushed
the
silence-output-of-ci-builds
branch
6 times, most recently
from
a85b7fd to
d337483
Compare
The output of pre-commit builds on both CI and locally is now limited to only show errors, unless verbose variable is set. We are utilising aliases if possible but in case of pre-commits they are run in non-interactive shell which means that aliases do not work as expected so we have to run a few functions directly in other to show spinner. Extracted from apache#10368
potiuk
force-pushed
the
silence-output-of-ci-builds
branch
from
d337483 to
ff4b32e
Compare
mik-laj
reviewed
Aug 19, 2020
| if [[ -n ${SPIN_PID:=""} ]]; then | ||
| kill -HUP "${SPIN_PID}" || true | ||
| wait "${SPIN_PID}" || true | ||
| echo > "${DETECTED_TERMINAL}" |
Member
There was a problem hiding this comment.
What values can the variable DETECTED_TERMINAL have? I can see that this variable is always set to /dev/tty. Did I miss something?
Member
Author
There was a problem hiding this comment.
it can be /dev/tty if we cannot detect therminal with $(tty) (which happens inside pre-commit on git commit (it is always non-interactive by design)
Member
Author
There was a problem hiding this comment.
it can be /dev/tty if we cannot detect therminal with $(tty) (which happens inside pre-commit on git commit (it is always non-interactive by design)
elif [[ ${DETECTED_TERMINAL:=$(tty)} != "not a tty" ]]; then
Member
Author
There was a problem hiding this comment.
The whole thing is about trying to print progress to most likely terminal i fbuild happens insde pre-commit inside `git commit command - it won't always succeed but in vast majority of cases of developer workstation - it will
mik-laj
approved these changes
Aug 19, 2020
kaxil
approved these changes
Aug 19, 2020
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 13, 2020
The output of pre-commit builds on both CI and locally is now limited to only show errors, unless verbose variable is set. We are utilising aliases if possible but in case of pre-commits they are run in non-interactive shell which means that aliases do not work as expected so we have to run a few functions directly in other to show spinner. Extracted from apache#10368 (cherry picked from commit 77a635e)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
The output of pre-commit builds on both CI and locally is now limited to only show errors, unless verbose variable is set. We are utilising aliases if possible but in case of pre-commits they are run in non-interactive shell which means that aliases do not work as expected so we have to run a few functions directly in other to show spinner. Extracted from apache#10368 (cherry picked from commit 77a635e)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
The output of pre-commit builds on both CI and locally is now limited to only show errors, unless verbose variable is set. We are utilising aliases if possible but in case of pre-commits they are run in non-interactive shell which means that aliases do not work as expected so we have to run a few functions directly in other to show spinner. Extracted from #10368 (cherry picked from commit 77a635e)
potiuk
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
The output of pre-commit builds on both CI and locally is now limited to only show errors, unless verbose variable is set. We are utilising aliases if possible but in case of pre-commits they are run in non-interactive shell which means that aliases do not work as expected so we have to run a few functions directly in other to show spinner. Extracted from #10368 (cherry picked from commit 77a635e)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
The output of pre-commit builds on both CI and locally is now limited to only show errors, unless verbose variable is set. We are utilising aliases if possible but in case of pre-commits they are run in non-interactive shell which means that aliases do not work as expected so we have to run a few functions directly in other to show spinner. Extracted from apache#10368 (cherry picked from commit 77a635e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of pre-commit builds on both CI and locally
is now limited to only show errors, unless verbose
variable is set.
We are utilising aliases if possible but in case of
pre-commits they are run in non-interactive shell which
means that aliases do not work as expected so we have
to run a few functions directly in other to
show spinner.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.