Simplified GCSTaskHandler configuration #10365
Conversation
boring-cyborg
bot
added
area:docs
area:logging
provider:google
|
CC: @mhenc |
| type: string | ||
| example: ~ | ||
| default: "" | ||
| - name: stackdriver_key_path |
There was a problem hiding this comment.
I am not sure if there is 'deprecation policy' but if someone was actually using this setting. After upgrade it will stop working.
There was a problem hiding this comment.
This option has not yet been found in any release.
| ) | ||
| client = storage.Client( | ||
| credentials=credentials, | ||
| client_info=ClientInfo(client_library_version='airflow_v' + version.version), |
There was a problem hiding this comment.
what is 'airflow_v'? - looks magical for me.
There was a problem hiding this comment.
This is a "User Agent" that allows you to track on the Google side which versions of Airflow your users are using. This identical identifier is used each time a client is created.
There was a problem hiding this comment.
Ok, why it's not in any constant then?
There was a problem hiding this comment.
I'll make it a constant in the next PR because it repeats in 3 places. It is recommended to use Hooks where this constant is already defined.
|
@potiuk Can I ask for a look? |
| ) | ||
| client = storage.Client( | ||
| credentials=credentials, | ||
| client_info=ClientInfo(client_library_version='airflow_v' + version.version), |
There was a problem hiding this comment.
Ok, why it's not in any constant then?
| description: | | ||
| Path to GCP Credential JSON file. If omitted, authorization based on `the Application Default | ||
| Path to Google Credential JSON file. If omitted, authorization based on `the Application Default | ||
| Credentials |
There was a problem hiding this comment.
| Credentials | |
| Credentials` |
There was a problem hiding this comment.
I have a closing character already.
3 participants
The change aims to simplify the configuration of logging, to prevent corruption of the instance configuration by changing the value controlled by the user - connection entry. If you configure a backend secret, it also means the webserver doesn't need to connect to it. This simplifies setups with multiple GCP projects.
This also makes the configuration of the Backend Secret and the StackdriverTaskHandler similar.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.