-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Amazon SES hook #10004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amazon SES hook #10004
Conversation
|
Are you interested to add email backend for SES? This will allow a similar goal to be achieved with more flexibility. |
Hi @mik-laj , does implementing that means I should close this PR or I should create a new one or add that functionality within this PR? |
|
All solutions are correct :-D |
Cool, if you don't mind, probably I'd like to merge this PR first and make another PR later to keep both features separated. |
SGTM 👍 |
feluelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks very good to me :)
Only a minor suggestion I have.
…module (PR feedback)
|
I am reverting this one as it broke master. Backport Packages were failing and it was merged by mistake. @ipeluffo Can you please re-do the ticket and fix the failing import ;) |
This reverts commit f06fe61.
|
Reverted. Please re-open @ipeluffo and re-submit the PR as a new one. We want to have the SES hook in :) |
|
I am sorry @ipeluffo - my fault. Thanks Jarek. |
|
No worries @feluelle :). It happens. I think it does not help that we might have the quarantined build fail occasionally and we still merge the changes, this makes us into the uncomfortable habit of merging not-entrly green build. I hope in a few weeks we will handle the quarantined tests and squash them (Still gathering stats) and eventually we will even disable the merge of non-fully green builds (or at least think hard before doing it). |
|
@ipeluffo ping :-) can you PR this again? |
|
Sorry for the delay responding, I've been off for a few days. I'll try to make a new PR between today and tomorrow morning. Thanks |
|
New PR created: #10391 |
This PR adds a new hook for Amazon Simple Email Service (SES).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.