Increase typing coverage #9708
Description
Helllo,
We've introduced mypy, but it's not very useful if we don't have type annotations. I think it's worth starting with the providers package, which is most often used by end-users. Currently, our annotation coverage is 47%. I will be happy when we have 75% coverage for each provider.
0.000000 dingding
0.000000 opsgenie
0.000000 presto
0.000000 qubole
0.000000 samba
0.000000 zendesk
16.666650 ssh
16.666667 oracle
16.666667 yandex
16.666700 odbc
21.428550 databricks
25.000000 exasol
25.000000 jdbc
25.000000 postgres
25.000000 singularity
25.000000 snowflake
27.380950 slack
27.964227 amazon
33.333333 sftp
46.153850 imap
50.733332 microsoft
66.761375 cncf
67.857150 salesforce
69.255826 google
71.250000 ftp
83.333300 openfaas
87.500000 redis
87.921875 apache
88.333340 mysql
88.888900 papermill
96.875000 mongo
100.000000 celery
100.000000 cloudant
100.000000 datadog
100.000000 discord
100.000000 docker
100.000000 elasticsearch
100.000000 facebook
100.000000 grpc
100.000000 hashicorp
100.000000 http
100.000000 jenkins
100.000000 jira
100.000000 pagerduty
100.000000 segment
100.000000 sendgrid
100.000000 sqlite
100.000000 vertica
You can also check the results using the command below.
MP_DIR=$(mktemp -d); mypy --linecount-report ${MP_DIR} airflow/; cat "${MP_DIR}/linecount.txt" | grep providers | grep -v example_dags | awk '
$4 != 0 {
split($5, a, ".");
print 100.00 * ($3/$4), a[3]
}'| awk '
{ sum[$2] += $1; N[$2]++ }
END {
for (key in sum) {
avg = sum[key] / N[key];
printf "%f %s\n", avg, key;
}
}' | sort -gIf you decide to finish this ticket you don't have to do all the work yourself. One PR can only deal with a single file/provider and it's ok.
If anyone is interested in this task, I am willing to provide all the necessary tips and information.
Are you wondering how to start contributing to this project? Start by reading our contributor guide
Best regards,
Kamil Breguła
CC: @ephraimbuddy @OmairK