Skip to content

Edit Connection form crashes silently when connection has invalid extra JSON #66591

Description

@shashbha14

Under which category would you file this issue?

Airflow Core

Apache Airflow version

3.2.1

What happened and how to reproduce it?

I have found that the JSON.parse() function call in ConnectionForm.tsx on line
85 does not have a try-catch block around it:
setConf(JSON.stringify(JSON.parse(initialConnection.extra), undefined, 2));
Thus, any connections with invalid JSON inside the extra object will cause
an exception to be thrown when opening the form. This issue can be easily
solved using the code from line 103 to 110 in the same file.
Reproducibility:

  1. Create a new connection with invalid JSON inside the extra object
  2. Attempt to open Edit Connection form

What you think should happen instead?

Edit form should work properly.

Operating System

Not applicable

Deployment

Other

Apache Airflow Provider(s)

No response

Versions of Apache Airflow Providers

No response

Official Helm Chart version

Not Applicable

Kubernetes Version

Not Applicable

Helm Chart configuration

No response

Docker Image customizations

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Labels

area:UIRelated to UI/UX. For Frontend Developers.area:corekind:bugThis is a clearly a bug

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions