-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Description
Apache Airflow Provider(s)
mysql
Versions of Apache Airflow Providers
any
Apache Airflow version
2.3.2 (latest released)
Operating System
debian
Deployment
Other Docker-based deployment
Deployment details
No response
What happened
If you pass an ssl-mode paramerter in a mysql connection using mysqldb client. That parameter does not get passed through to the mysqldb client.
What you think should happen instead
The parameter should be passed through, so that the client actually connects with the desired SSL mode.
How to reproduce
Add a connection with the extra parameter ssl-mode: "DISABLED". Use MySQLdb client. Connect to a mysql db which has ssl mode disabled. See that the parameter actually is not passed through.
Anything else
Parameter should be passed through here:
https://github.com/apache/airflow/blob/main/airflow/providers/mysql/hooks/mysql.py#L119
mysqldb offers the option:
https://mysqlclient.readthedocs.io/user_guide.html ---> ssl-mode
or
https://dev.mysql.com/doc/dev/connector-python/8.0/tutorials/getting_started.html --> ssl-mode
accepted params are: REQUIRED, DISABLED, VERIFY_CA, VERIFY_IDENTITY
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct