-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Closed
Labels
kind:taskA task that needs to be completed as part of a larger issueA task that needs to be completed as part of a larger issue
Milestone
Description
Apache Airflow version
2.2.2 (latest released)
Operating System
Ubuntu
Deployment
Virtualenv installation
What happened
There are different names for the same keyword argument:
BaseSqlOperator(hook_params) - by PR #18718
Connection.get_hook(hook_kwargs) - by PR #18718
SqlSensor(hook_params) - by PR #18431
Plan:
- Rename
hook_kwargstohook_paramsin Connection.get_hook
airflow/airflow/models/connection.py
Line 288 in 6df69df
def get_hook(self, *, hook_kwargs=None): - Rename usage in BaseSqlOperator
airflow/airflow/operators/sql.py
Line 68 in 6df69df
hook = conn.get_hook(hook_kwargs=self.hook_params) - Rename usage in SqlSensor
https://github.com/kazanzhy/airflow/blob/459a652e831785f362fd3443c46b53161f8bfc72/airflow/sensors/sql.py#L87
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
kind:taskA task that needs to be completed as part of a larger issueA task that needs to be completed as part of a larger issue