Skip to content

Several statsd timers record seconds rather than milliseconds #10629

@mjpieters

Description

@mjpieters

Apache Airflow version: 1.10.11

What happened:

Statsd timers for 3 categories are reporting values 1000x off as the code passes seconds, rather rather than milliseconds (or a timedelta() instance) to StatsClient.timing().

What you expected to happen:

The timings should be reported in milliseconds.

How to reproduce it:

Enable the statsd client and track reporting timings for:

  • dag.loading-duration.* (emitted from models/dagbag.py)
  • dag.<dag_id>.<task_id>.duration (emitted from models/taskinstance.py)
  • dag_processing.last_duration.<filename> (emitted from utils/dag_processing.py) and it's deprecated alias dag_processing.last_runtime.*

Anything else we need to know:

This was reported before, for the dag_processing.last_* stats, at https://issues.apache.org/jira/browse/AIRFLOW-6088.
The accompanying pull request #6682, fixed 2 out of 3 of these, but only for Airflow 2.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:bugThis is a clearly a bugpriority:criticalShowstopper bug that should be patched immediately

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions