Replies: 6 comments 3 replies
-
|
Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval. |
Beta Was this translation helpful? Give feedback.
-
|
cc @kaxil something we overlooked in the cleanup? |
Beta Was this translation helpful? Give feedback.
-
|
We swapped Multiprocessing with Task SDK machinery in #44972 11acefa was just a cleanup. |
Beta Was this translation helpful? Give feedback.
-
|
@kaxil sure, but mp_start_method no longer exists outside of the config. if someone wants to use a different multiprocessing method they no longer can / need to hack something. I discovered this looking at #54510 , where I realized another annoyance, uvicorn also sets spawn in a way that will make it a default if it isn't already set, so there will be more unexpected behavior there if someone is expecting forking. |
Beta Was this translation helpful? Give feedback.
-
|
Yup, teething issues with Airflow 2 to 3 migration. PRs welcomed |
Beta Was this translation helpful? Give feedback.
-
Yes. Annoyances when we removed things that were never intended to be used are expected. Following what @kaxil wrote - if you feel that your case is also bothering for others and that it is worth turning that into a featire - feel free to a) discuss in devlist, and b) - ideally at the same time - make a PR to implement it. Otherwise - bite the bullet and fight with the annoyance - possibly it;s only you. I comvert it into a discussion, but if anyone wants to contribute some feature that is generic and useful enough - maybe resurrecting it from the past - opening PR is really best place to start. |
Beta Was this translation helpful? Give feedback.
-
|
@potiuk I don't necessarily have time to reimplement this at the moment (and don’t actually need it, just noticed and thought it was worth flagging), but it’s most certainly a regression and bug that this was a configurable feature that doesn’t work at present. I’d suggest leaving it as an issue in case someone else stumbles on it in the meantime before it’s either fixed or removed. If removing it is acceptable I can do that PR pretty easily 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
Yeah. I have not seen it is in config still - feel free to remove it. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, feel free to remove please. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Apache Airflow version
main (development)
If "Other Airflow 2 version" selected, which one?
No response
What happened?
looks like 11acefa deleted code that provided functionality for mp_start_method, among other things.
What you think should happen instead?
either remove mp_start_method from config, or re-add implementation.
How to reproduce
n/a
Operating System
all
Versions of Apache Airflow Providers
No response
Deployment
Official Apache Airflow Helm Chart
Deployment details
No response
Anything else?
No response
Are you willing to submit PR?
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions