|
23 | 23 | import pytest |
24 | 24 |
|
25 | 25 | from airflow.models import Connection |
26 | | -from airflow.providers.common.compat.sdk import AirflowNotFoundException |
| 26 | +from airflow.providers.common.compat.sdk import ( |
| 27 | + AirflowNotFoundException, |
| 28 | + AirflowOptionalProviderFeatureException, |
| 29 | +) |
27 | 30 | from airflow.providers.samba.hooks.samba import SambaHook |
28 | 31 |
|
29 | 32 | try: |
@@ -63,6 +66,7 @@ def test_context_manager(self, get_conn_mock, register_session): |
63 | 66 | "password": CONNECTION.password, |
64 | 67 | "port": 445, |
65 | 68 | "connection_cache": {}, |
| 69 | + "auth_protocol": "negotiate", |
66 | 70 | } |
67 | 71 | cache = kwargs.get("connection_cache") |
68 | 72 | mock_connection = mock.Mock() |
@@ -117,6 +121,7 @@ def test_method(self, get_conn_mock, name): |
117 | 121 | "username": CONNECTION.login, |
118 | 122 | "password": CONNECTION.password, |
119 | 123 | "port": 445, |
| 124 | + "auth_protocol": "negotiate", |
120 | 125 | } |
121 | 126 | with mock.patch("smbclient." + name) as p: |
122 | 127 | kwargs = {} |
@@ -191,6 +196,116 @@ def test__join_path( |
191 | 196 | hook = SambaHook("samba_default", share_type=path_type) |
192 | 197 | assert hook._join_path(path) == full_path |
193 | 198 |
|
| 199 | + @mock.patch.dict("sys.modules", {"krb5": mock.MagicMock()}) |
| 200 | + @mock.patch("smbclient.register_session") |
| 201 | + @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
| 202 | + def test_kerberos_auth_via_extra(self, get_conn_mock, register_session): |
| 203 | + """Test that auth_protocol='kerberos' from extra is passed to smbclient.""" |
| 204 | + connection = Connection( |
| 205 | + host="kerb-host.example.com", |
| 206 | + schema="share", |
| 207 | + extra='{"auth_protocol": "kerberos"}', |
| 208 | + ) |
| 209 | + get_conn_mock.return_value = connection |
| 210 | + register_session.return_value = None |
| 211 | + with SambaHook("samba_default"): |
| 212 | + _, kwargs = tuple(register_session.call_args_list[0]) |
| 213 | + assert kwargs["auth_protocol"] == "kerberos" |
| 214 | + assert kwargs["username"] is None |
| 215 | + assert kwargs["password"] is None |
| 216 | + |
| 217 | + @mock.patch.dict("sys.modules", {"krb5": mock.MagicMock()}) |
| 218 | + @mock.patch("smbclient.register_session") |
| 219 | + @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
| 220 | + def test_kerberos_auth_via_legacy_auth_key(self, get_conn_mock, register_session): |
| 221 | + """Test backward compat: extra {"auth": "kerberos"} is recognized.""" |
| 222 | + connection = Connection( |
| 223 | + host="kerb-host.example.com", |
| 224 | + schema="share", |
| 225 | + extra='{"auth": "kerberos"}', |
| 226 | + ) |
| 227 | + get_conn_mock.return_value = connection |
| 228 | + register_session.return_value = None |
| 229 | + with SambaHook("samba_default"): |
| 230 | + _, kwargs = tuple(register_session.call_args_list[0]) |
| 231 | + assert kwargs["auth_protocol"] == "kerberos" |
| 232 | + |
| 233 | + @mock.patch.dict("sys.modules", {"krb5": mock.MagicMock()}) |
| 234 | + @mock.patch("smbclient.register_session") |
| 235 | + @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
| 236 | + def test_kerberos_auth_via_constructor(self, get_conn_mock, register_session): |
| 237 | + """Test that constructor auth_protocol overrides extra.""" |
| 238 | + connection = Connection( |
| 239 | + host="kerb-host.example.com", |
| 240 | + schema="share", |
| 241 | + login="user", |
| 242 | + password="pass", |
| 243 | + ) |
| 244 | + get_conn_mock.return_value = connection |
| 245 | + register_session.return_value = None |
| 246 | + with SambaHook("samba_default", auth_protocol="kerberos"): |
| 247 | + _, kwargs = tuple(register_session.call_args_list[0]) |
| 248 | + assert kwargs["auth_protocol"] == "kerberos" |
| 249 | + |
| 250 | + @mock.patch("smbclient.register_session") |
| 251 | + @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
| 252 | + def test_legacy_auth_key_ignored_when_invalid(self, get_conn_mock, register_session): |
| 253 | + """Test that extra {"auth": "basic"} is ignored and defaults to negotiate.""" |
| 254 | + connection = Connection( |
| 255 | + host="host", |
| 256 | + schema="share", |
| 257 | + login="user", |
| 258 | + password="pass", |
| 259 | + extra='{"auth": "basic"}', |
| 260 | + ) |
| 261 | + get_conn_mock.return_value = connection |
| 262 | + register_session.return_value = None |
| 263 | + with SambaHook("samba_default"): |
| 264 | + _, kwargs = tuple(register_session.call_args_list[0]) |
| 265 | + assert kwargs["auth_protocol"] == "negotiate" |
| 266 | + |
| 267 | + @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
| 268 | + def test_invalid_auth_protocol_raises(self, get_conn_mock): |
| 269 | + """Test that an invalid auth_protocol raises ValueError.""" |
| 270 | + connection = Connection( |
| 271 | + host="host", |
| 272 | + schema="share", |
| 273 | + extra='{"auth_protocol": "invalid"}', |
| 274 | + ) |
| 275 | + get_conn_mock.return_value = connection |
| 276 | + with pytest.raises(ValueError, match="Invalid auth_protocol 'invalid'"): |
| 277 | + SambaHook("samba_default") |
| 278 | + |
| 279 | + @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
| 280 | + def test_kerberos_without_dependency_raises(self, get_conn_mock): |
| 281 | + """Test that kerberos auth without krb5 installed raises AirflowOptionalProviderFeatureException.""" |
| 282 | + connection = Connection( |
| 283 | + host="kerb-host.example.com", |
| 284 | + schema="share", |
| 285 | + extra='{"auth_protocol": "kerberos"}', |
| 286 | + ) |
| 287 | + get_conn_mock.return_value = connection |
| 288 | + with mock.patch.dict("sys.modules", {"krb5": None}): |
| 289 | + with pytest.raises(AirflowOptionalProviderFeatureException, match="krb5"): |
| 290 | + SambaHook("samba_default") |
| 291 | + |
| 292 | + @mock.patch("smbclient.register_session") |
| 293 | + @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
| 294 | + def test_ntlm_auth(self, get_conn_mock, register_session): |
| 295 | + """Test that auth_protocol='ntlm' is passed correctly.""" |
| 296 | + connection = Connection( |
| 297 | + host="host", |
| 298 | + schema="share", |
| 299 | + login="user", |
| 300 | + password="pass", |
| 301 | + extra='{"auth_protocol": "ntlm"}', |
| 302 | + ) |
| 303 | + get_conn_mock.return_value = connection |
| 304 | + register_session.return_value = None |
| 305 | + with SambaHook("samba_default"): |
| 306 | + _, kwargs = tuple(register_session.call_args_list[0]) |
| 307 | + assert kwargs["auth_protocol"] == "ntlm" |
| 308 | + |
194 | 309 | @mock.patch("airflow.providers.samba.hooks.samba.smbclient.open_file", return_value=mock.Mock()) |
195 | 310 | @mock.patch(f"{BASEHOOK_PATCH_PATH}.get_connection") |
196 | 311 | def test_open_file(self, get_conn_mock, open_file_mock): |
|
0 commit comments