[AIRFLOW-906] Update Code icon from lightning bolt to file

djarratt · aoen · commit bc47200711be · 2017-02-24T15:00:51.000-08:00
Lightning bolts are not a visual metaphor for code or files. Since Glyphicon doesn't have a code icon (<>, for instance), we should use its file icon. Dear Airflow Maintainers, Please accept this PR that addresses the following issues: AIRFLOW-906 Testing Done: None. Before/After screenshots in AIRFLOW-906 (https://i ssues.apache.org/jira/browse/AIRFLOW-906) Update Code icon from lightning bolt to file Lightning bolts are not a visual metaphor for code or files. Since Glyphicon doesn't have a code icon (<>, for instance), we should use its file icon. Merge pull request #1 from djarratt/djarratt- patch-1 Update Code icon from lightning bolt to file AIRFLOW-906 change glyphicon flash to file Merge pull request #2 from djarratt/djarratt- patch-2 AIRFLOW-906 change glyphicon flash to file Closes #2104 from djarratt/master
diff --git a/airflow/www/static/bootstrap-theme.css b/airflow/www/static/bootstrap-theme.css
@@ -3068,7 +3068,7 @@ tbody.collapse.in {
 .glyphicon-log-in:before {
   content: "\e161";
 }
-.glyphicon-flash:before {
+.glyphicon-file:before {
   content: "\e162";
 }
 .glyphicon-log-out:before {
diff --git a/airflow/www/templates/airflow/dag.html b/airflow/www/templates/airflow/dag.html
@@ -90,7 +90,7 @@ <h4 class="pull-right">
       </li>
       <li>
         <a href="{{ url_for("airflow.code", dag_id=dag.dag_id, root=root) }}">
-          <span class="glyphicon glyphicon-flash" aria-hidden="true"></span>
+          <span class="glyphicon glyphicon-file" aria-hidden="true"></span>
           Code
         </a>
       </li>
diff --git a/airflow/www/templates/airflow/dags.html b/airflow/www/templates/airflow/dags.html
@@ -167,7 +167,7 @@ <h2>DAGs</h2>
 
                 <!-- Code -->
                 <a href="{{ url_for("airflow.code", dag_id=dag.dag_id) }}" title="Code View">
-                    <span class="glyphicon glyphicon-flash" aria-hidden="true"></span>
+                    <span class="glyphicon glyphicon-file" aria-hidden="true"></span>
                 </a>
 
                 <!-- Logs -->
diff --git a/airflow/www/templates/airflow/list_dags.html b/airflow/www/templates/airflow/list_dags.html
@@ -167,7 +167,7 @@ <h2>DAGs</h2>
                 <i class="icon-align-left"></i>
               </a>
               <a href="{{ url_for("airflow.code", dag_id=row.dag_id) }}" title="Code View">
-                <span class="glyphicon glyphicon-flash" aria-hidden="true"></span>
+                <span class="glyphicon glyphicon-file" aria-hidden="true"></span>
               </a>
               <a href="{{ url_for("airflow.refresh", dag_id=row.dag_id) }}" title="Refresh">
                 <span class="glyphicon glyphicon-refresh" aria-hidden="true"></span>

Original file line number	Diff line number	Diff line change
`@@ -3068,7 +3068,7 @@ tbody.collapse.in {`
`3068`	`3068`	`.glyphicon-log-in:before {`
`3069`	`3069`	`content: "\e161";`
`3070`	`3070`	`}`
`3071`		`-.glyphicon-flash:before {`
	`3071`	`+.glyphicon-file:before {`
`3072`	`3072`	`content: "\e162";`
`3073`	`3073`	`}`
`3074`	`3074`	`.glyphicon-log-out:before {`