Repository navigation
Commit 9a85faa
Fix provider distribution builds failing with flit 4 (#71118)
* Fix provider distribution builds failing with flit 4
flit 4.0 removed the --setup-py/--no-setup-py options, so every flit-backed
provider build now aborts during argument parsing as soon as flit 4 resolves.
Not generating setup.py has been flit's default since well before the 3.12
floor breeze requires, so no longer asking for it explicitly leaves the built
distributions unchanged.
* Cap flit below 4 so provider distributions keep valid metadata
`flit build` does not use PEP 517 build isolation, so whichever flit_core is
installed becomes the backend for every provider distribution and the
`flit_core==3.12.0` pin each provider declares never applies on the path we
release from. flit_core 4.0.1 writes Import-Name and Import-Namespace without a
trailing newline (pypa/flit#813), consuming the blank
line that separates the metadata headers from the description, so the resulting
METADATA parses with MissingHeaderBodySeparatorDefect.
Removal of the cap is tracked at
#71121.
* Drop the flit flag regression test
The assertion mirrors the argv literal it guards and mocks away the argument
parser that actually rejected the flag, so it detects reverts rather than the
class of breakage it was written for. The provider distribution build jobs
cover that.
* Rest the flit cap on the unvalidated backend rather than the 4.0.1 defect
flit 4.0.2 fixed the METADATA corruption the comment cited, but the reason to
hold the backend at 3.12.0 is that nothing has exercised flit 4 against provider
distributions or the reproducible-build checks.
---------
Co-authored-by: Rahul Vats <[email protected]>1 parent f69c195 commit 9a85faa
4 files changed
Lines changed: 12 additions & 8 deletions
File tree
- dev/breeze
- src/airflow_breeze/prepare_providers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
52 | 56 | | |
53 | 57 | | |
54 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
| 254 | + | |
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments