Skip to content

Commit 8037e9a

Browse files
authored
Skip ts-sdk supervisor schema check for doc-only changes (#70022)
ts-sdk/*.md edits (e.g. README) currently match TS_SDK_FILES and keep the check-ts-sdk-supervisor-schema prek hook from being skipped, so a documentation-only change needlessly regenerates and diffs the generated supervisor schema. Documentation does not affect it.
1 parent c7bc7ac commit 8037e9a

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

‎dev/breeze/src/airflow_breeze/utils/selective_checks.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,8 @@ def __hash__(self):
462462
r"^java-sdk/(?!.*\.md$).*",
463463
],
464464
FileGroupForCi.TS_SDK_FILES: [
465-
r"^ts-sdk/",
465+
# `.md` excluded — doc-only edits do not affect the generated supervisor schema.
466+
r"^ts-sdk/(?!.*\.md$).*",
466467
],
467468
FileGroupForCi.ASSET_FILES: [
468469
r"^airflow-core/src/airflow/assets/",

‎dev/breeze/tests/test_selective_checks.py‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1788,6 +1788,16 @@ def test_ktlint_hook_only_runs_for_java_sdk_changes(files: tuple[str, ...], ktli
17881788
True,
17891789
id="skipped when no ts-sdk files change",
17901790
),
1791+
pytest.param(
1792+
("ts-sdk/README.md",),
1793+
True,
1794+
id="skipped when only ts-sdk docs change",
1795+
),
1796+
pytest.param(
1797+
("ts-sdk/example/README.md",),
1798+
True,
1799+
id="skipped when only nested ts-sdk docs change",
1800+
),
17911801
],
17921802
)
17931803
def test_check_ts_sdk_supervisor_schema_hook_only_runs_for_relevant_changes(

0 commit comments

Comments
 (0)