You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 364a7d0
Browse filesBrowse the repository at this point in the historyBrowse files
Thread bundle_path through sync_bag_to_db and skip listener args when no listener is registered
Address review feedback:
- sync_bag_to_db() now forwards dagbag.bundle_path to
update_dag_parsing_results_in_db(), so the CLI/dag.test() path no
longer falls back to the bundle-instantiating full_file_path()
inside the parsing transaction.
- Restore a cheap has_listeners early exit so the fallback
(select + full_file_path) never runs when no listener plugin is
registered, regardless of whether bundle_path was threaded down.
- Use the per-file bundle_name_ consistently when building the
listener filename in the new-error branch.
- Add regression tests: through sync_bag_to_db() end-to-end (fails
if a production caller stops forwarding bundle_path), for the
existing-error listener branch, and for the no-listener fallback.
Fix DAG import errors being silently dropped (never shown in the *Import Errors* view). While recording an import error, ``_update_import_errors`` called ``ParseImportError.full_file_path()`` to build the import-error listener argument. ``full_file_path()`` re-instantiates the DAG bundle and, for some bundle types (e.g. the Git bundle), resolves an Airflow Connection; doing so inside the DAG-parsing transaction could roll back the not-yet-flushed import error row, leaving the DAG marked as broken with nothing shown in the UI. The already-known bundle path is now threaded down to ``_update_import_errors`` and used to build the listener filename directly, so the bundle is no longer re-instantiated inside the transaction.
1
+
Fix DAG import errors being silently dropped (never shown in the *Import Errors* view). While recording an import error, ``_update_import_errors`` called ``ParseImportError.full_file_path()`` to build the import-error listener argument. ``full_file_path()`` re-instantiates the DAG bundle and, for some bundle types (e.g. the Git bundle), resolves an Airflow Connection; doing so inside the DAG-parsing transaction could roll back the not-yet-flushed import error row, leaving the DAG marked as broken with nothing shown in the UI. The already-known bundle path is now threaded down to ``_update_import_errors`` (from both the DAG processor and ``sync_bag_to_db``) and used to build the listener filename directly, so the bundle is no longer re-instantiated inside the transaction. Additionally, when no listener plugin is registered, the listener arguments are no longer computed at all.
0 commit comments