Repository navigation
Commit 1a2784d
authored
Fix ExternalTaskSensor to use timeout parameter in deferrable mode (#… (#62556)
* Fix ExternalTaskSensor to use timeout parameter in deferrable mode (#62516)
ExternalTaskSensor was incorrectly using execution_timeout instead of timeout when deferring in deferrable mode, causing inconsistent behavior across poke, reschedule, and deferrable modes.
Changes:
- Updated execute() to use timedelta(seconds=self.timeout) with fallback to execution_timeout
- Added comprehensive test coverage for timeout behavior in deferrable mode
- Ensures consistent timeout semantics across all sensor modes
* Simplify timeout logic and update tests
Remove incorrect fallback to execution_timeout. Timeout parameter always has a default value from config, so no fallback is needed or correct.
Update tests to validate correct behavior matching other sensors
* Remove empty SOLUTION.md file
* Fix ExternalTaskSensor timeout handling in deferrable mode
- Implement fallback to execution_timeout when timeout is not set (0 or None)
- Update tests to cover 3 distinct scenarios:
1. timeout set, execution_timeout not set
2. timeout not set (0), execution_timeout set
3. timeout and execution_timeout both set (priority test)
- Fix whitespace issue flagged by ruff
* Retrigger CI1 parent d4765cf commit 1a2784d
2 files changed
Lines changed: 78 additions & 2 deletions
File tree
- providers/standard
- src/airflow/providers/standard/sensors
- tests/unit/standard/sensors
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
435 | 440 | | |
436 | 441 | | |
437 | 442 | | |
438 | | - | |
| 443 | + | |
439 | 444 | | |
440 | 445 | | |
441 | 446 | | |
| |||
453 | 458 | | |
454 | 459 | | |
455 | 460 | | |
456 | | - | |
| 461 | + | |
457 | 462 | | |
458 | 463 | | |
459 | 464 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1049 | 1049 | | |
1050 | 1050 | | |
1051 | 1051 | | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
1052 | 1123 | | |
1053 | 1124 | | |
1054 | 1125 | | |
| |||
0 commit comments