Make brokerName immutable in RegionBroker#1917
Merged
cshannon merged 1 commit intoapache:mainfrom Apr 14, 2026
Merged
Conversation
The brokerName should come from BrokerService and should only be configured on first creation. This update changes RegionBroker so that it gets the name from the broker service during construction and verifies that it is not null. The other benefit of this is that BrokerService always validates the name has valid characters. This change also cleans up the name regex to get rid of unnecessary escapes and also adds some regex tests.
jbonofre
approved these changes
Apr 14, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.3.0
cshannon
added a commit
to cshannon/activemq
that referenced
this pull request
Apr 14, 2026
The brokerName should come from BrokerService and should only be configured on first creation. This update changes RegionBroker so that it gets the name from the broker service during construction and verifies that it is not null. The other benefit of this is that BrokerService always validates the name has valid characters. This change also cleans up the name regex to get rid of unnecessary escapes and also adds some regex tests. (cherry picked from commit 084502a)
cshannon
added a commit
to cshannon/activemq
that referenced
this pull request
Apr 14, 2026
The brokerName should come from BrokerService and should only be configured on first creation. This update changes RegionBroker so that it gets the name from the broker service during construction and verifies that it is not null. The other benefit of this is that BrokerService always validates the name has valid characters. This change also cleans up the name regex to get rid of unnecessary escapes and also adds some regex tests. (cherry picked from commit 084502a)
cshannon
added a commit
that referenced
this pull request
Apr 14, 2026
The brokerName should come from BrokerService and should only be configured on first creation. This update changes RegionBroker so that it gets the name from the broker service during construction and verifies that it is not null. The other benefit of this is that BrokerService always validates the name has valid characters. This change also cleans up the name regex to get rid of unnecessary escapes and also adds some regex tests. (cherry picked from commit 084502a)
cshannon
added a commit
that referenced
this pull request
Apr 14, 2026
The brokerName should come from BrokerService and should only be configured on first creation. This update changes RegionBroker so that it gets the name from the broker service during construction and verifies that it is not null. The other benefit of this is that BrokerService always validates the name has valid characters. This change also cleans up the name regex to get rid of unnecessary escapes and also adds some regex tests. (cherry picked from commit 084502a)
pburgess147
pushed a commit
to peersoftware/activemq
that referenced
this pull request
Apr 17, 2026
The brokerName should come from BrokerService and should only be configured on first creation. This update changes RegionBroker so that it gets the name from the broker service during construction and verifies that it is not null. The other benefit of this is that BrokerService always validates the name has valid characters. This change also cleans up the name regex to get rid of unnecessary escapes and also adds some regex tests. (cherry picked from commit 084502a)
jgallimore
added a commit
to tomitribe/activemq
that referenced
this pull request
Apr 24, 2026
Cherry-picked from 5.19.x: 9e69872
jgallimore
added a commit
to tomitribe/activemq
that referenced
this pull request
Apr 24, 2026
Cherry-picked from 5.19.x: 9e69872
jgallimore
added a commit
to tomitribe/activemq
that referenced
this pull request
Apr 24, 2026
Cherry-picked from 6.2.x: 8c929d0
jgallimore
added a commit
to tomitribe/activemq
that referenced
this pull request
Apr 24, 2026
Cherry-picked from 6.2.x: 8c929d0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The brokerName should come from BrokerService and should only be configured on first creation. This update changes RegionBroker so that it gets the name from the broker service during construction and verifies that it is not null.
The other benefit of this is that BrokerService always validates the name has valid characters. This change also cleans up the name regex to get rid of unnecessary escapes and also adds some regex tests.