Skip to content

Ensure AMQP protocol marshals messages before passing to broker#1859

Merged
cshannon merged 1 commit intoapache:mainfrom
cshannon:amqp-marshall-receive
Mar 30, 2026
Merged

Ensure AMQP protocol marshals messages before passing to broker#1859
cshannon merged 1 commit intoapache:mainfrom
cshannon:amqp-marshall-receive

Conversation

@cshannon
Copy link
Copy Markdown
Contributor

@cshannon cshannon commented Mar 30, 2026

This change brings the behavior inline with other protocols and will prevent a future race condition during copy/dispatch as the data will already be marshaled.

This closes #1858

This change brings the behaior inline with other protocols and will
prevent a future race condition during copy/dispatch as the data will
already be marshaled.

This closes apache#1858
@cshannon cshannon requested review from jbonofre and tabish121 March 30, 2026 15:57
Copy link
Copy Markdown
Contributor

@tabish121 tabish121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshannon cshannon merged commit e8f10dd into apache:main Mar 30, 2026
10 checks passed
@cshannon cshannon deleted the amqp-marshall-receive branch March 30, 2026 16:26
cshannon added a commit to cshannon/activemq that referenced this pull request Mar 30, 2026
…he#1859)

This change brings the behaior inline with other protocols and will
prevent a future race condition during copy/dispatch as the data will
already be marshaled.

This closes apache#1858

(cherry picked from commit e8f10dd)
cshannon added a commit to cshannon/activemq that referenced this pull request Mar 30, 2026
…he#1859)

This change brings the behaior inline with other protocols and will
prevent a future race condition during copy/dispatch as the data will
already be marshaled.

This closes apache#1858

(cherry picked from commit e8f10dd)
cshannon added a commit that referenced this pull request Apr 2, 2026
… (#1861)

This change brings the behaior inline with other protocols and will
prevent a future race condition during copy/dispatch as the data will
already be marshaled.

This closes #1858

(cherry picked from commit e8f10dd)
cshannon added a commit that referenced this pull request Apr 2, 2026
… (#1860)

This change brings the behaior inline with other protocols and will
prevent a future race condition during copy/dispatch as the data will
already be marshaled.

This closes #1858

(cherry picked from commit e8f10dd)
pburgess147 pushed a commit to peersoftware/activemq that referenced this pull request Apr 17, 2026
…he#1859) (apache#1860)

This change brings the behaior inline with other protocols and will
prevent a future race condition during copy/dispatch as the data will
already be marshaled.

This closes apache#1858

(cherry picked from commit e8f10dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix AMQP race condition with concurrent dispatch and copy of messages

2 participants