Repository navigation
Commit f67eb5b
refactor(web): host the sandbox control in the right panel (pingdotgg#37)
The control landed in the sidebar footer, which pins it to the bottom of
the screen — far from the surfaces whose availability it governs. Move it
into the right panel's tab bar, beside the tab list, where it sits next
to the "Sandbox required" state it resolves.
`SandboxedRightPanelTabs` already resolves availability for the surface
gating, so it feeds the same `status` view to a `SandboxStatusControl`
passed down as `RightPanelTabs`' new `sandboxControl` slot — one query,
one atom, no extra RPC. `SidebarSandboxStatus` and its route/draft thread
resolution are deleted; the panel is only rendered for an active thread,
so there is no threadless case left to guard.
The sheet variant of the panel can be as narrow as 20rem, where the pill
plus the layout toggles would leave the tab list nothing. `compact` drops
the status text there — the indicator, the action and the hover title
carry it — and `aria-live` still announces the full label.
Co-authored-by: Claude Opus 5 <[email protected]>1 parent 1d19ca7 commit f67eb5b
5 files changed
Lines changed: 35 additions & 44 deletions
File tree
- apps/web/src/components
- sandbox
- sidebar
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| |||
500 | 501 | | |
501 | 502 | | |
502 | 503 | | |
| 504 | + | |
503 | 505 | | |
504 | 506 | | |
505 | 507 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
48 | 53 | | |
49 | 54 | | |
50 | 55 | | |
| |||
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
56 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
57 | 67 | | |
58 | 68 | | |
59 | 69 | | |
| |||
114 | 124 | | |
115 | 125 | | |
116 | 126 | | |
| 127 | + | |
117 | 128 | | |
118 | 129 | | |
119 | 130 | | |
| |||
129 | 140 | | |
130 | 141 | | |
131 | 142 | | |
132 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
133 | 151 | | |
134 | 152 | | |
135 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
19 | 31 | | |
20 | 32 | | |
21 | 33 | | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| |||
98 | 97 | | |
99 | 98 | | |
100 | 99 | | |
101 | | - | |
102 | 100 | | |
103 | 101 | | |
104 | 102 | | |
| |||
0 commit comments