v1.18: fix: set allocation size to 0 for transactions known to fail (backport of #2966)#2988
Merged
v1.18: fix: set allocation size to 0 for transactions known to fail (backport of #2966)#2988
Conversation
(cherry picked from commit 443246d) # Conflicts: # cost-model/src/cost_model.rs
Author
|
Cherry-pick of 443246d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
apfitzge
approved these changes
Sep 26, 2024
tao-stones
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Transactions with invalid system instructions are known to fail but still attempt to reserve allocation space in the cost model despite not actually persisting any new allocated accounts.
Summary of Changes
Fixes #
This is an automatic backport of pull request #2966 done by [Mergify](https://mergify.com).