Skip to content

fix toctou in program statistics merge_from - #11760

Merged
nagisa merged 1 commit into
anza-xyz:masterfrom
knQzx:fix-merge-from-toctou
Apr 6, 2026
Merged

nagisa merged 1 commit into
anza-xyz:masterfrom
knQzx:fix-merge-from-toctou

Conversation

@knQzx

@knQzx knQzx commented Apr 5, 2026

Copy link
Copy Markdown

summary

  • fix toctou race in ProgramStatistics::merge_from
  • interpreted_invocations was being re-loaded atomically instead of using the already loaded local variable

test plan

  • verified other fields already use the loaded value pattern correctly

fixes #11730

@knQzx
knQzx requested a review from a team as a code owner April 5, 2026 11:53
@Lichtso
Lichtso requested a review from nagisa April 5, 2026 14:11
@nagisa nagisa added the CI Pull Request is ready to enter CI label Apr 6, 2026
@nagisa
nagisa enabled auto-merge April 6, 2026 10:27
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Apr 6, 2026
@nagisa
nagisa added this pull request to the merge queue Apr 6, 2026
@codecov-commenter

codecov-commenter commented Apr 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.1%. Comparing base (289aa4e) to head (bba2b83).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #11760     +/-   ##
=========================================
- Coverage    83.1%    83.1%   -0.1%     
=========================================
  Files         857      857             
  Lines      321496   321496             
=========================================
- Hits       267445   267434     -11     
- Misses      54051    54062     +11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into anza-xyz:master with commit 0d7769e Apr 6, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

program-runtime: ProgramStatistics::merge_from re-reads interpreted_invocations instead of using the loaded value

4 participants