Missing term in calculation of TOTAL_VALUES. #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fjosw is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
rickstaa
added
ranks
rickstaa
approved these changes
Oct 8, 2022
Contributor
Author
|
Are you still considering to merge this @anuraghazra @rickstaa or should I close the PR? |
Collaborator
|
@fjosw I think this PR needs to be merged since it addresses a real bug. I however waited for @anuraghazra's approval since it wil influence ranks. |
Codecov ReportBase: 97.32% // Head: 96.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2116 +/- ##
==========================================
- Coverage 97.32% 96.66% -0.67%
==========================================
Files 22 22
Lines 3592 3803 +211
Branches 322 320 -2
==========================================
+ Hits 3496 3676 +180
- Misses 95 125 +30
- Partials 1 2 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
Before PRAfter |
Collaborator
|
@anuraghazra Merged as it does not seem to influence the ranks by too much. |
devantler
pushed a commit
to devantler/github-readme-stats
that referenced
this pull request
May 1, 2023
* fix: added missing term in calculation of TOTAL_VALUES. * fix: fix rank test * refactor: update code formatting * refactor: update code formatting Co-authored-by: rickstaa <[email protected]>
necofuryai
added a commit
to necofuryai/github-readme-stats
that referenced
this pull request
May 19, 2025
* fix: added missing term in calculation of TOTAL_VALUES. * fix: fix rank test * refactor: update code formatting * refactor: update code formatting Co-authored-by: rickstaa <[email protected]>
xhayper
pushed a commit
to xhayper/github-readme-stats
that referenced
this pull request
Jul 2, 2025
* fix: added missing term in calculation of TOTAL_VALUES. * fix: fix rank test * refactor: update code formatting * refactor: update code formatting Co-authored-by: rickstaa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found a missing term in the calculation of
TOTAL_VALUESused as input standard deviation for the CDF in calculateRank.