feat: 增加supportCSSTransform#988
feat: 增加supportCSSTransform#988xiaochong44 wants to merge 1 commit intoantvis:masterfrom xiaochong44:master
Conversation
|
⚡️ Deploying PR Preview... |
github-actions
bot
requested review from
YardWill,
lijinke666,
qubaomingg,
stone-lyl,
wjgogogo,
xingwanying,
yangzhanmei and
zxc0328
|
pr 标题改下～ |
| S2PivotSheetOptions { | ||
| // custom data set | ||
| readonly dataSet?: (spreadsheet: SpreadSheet) => BaseDataSet; | ||
| supportCSSTransform?: boolean; |
| */ | ||
| protected initGroups() { | ||
| const { width, height } = this.options; | ||
| const { width, height, supportCSSTransform = false } = this.options; |
There was a problem hiding this comment.
默认值统一设置在 packages/s2-core/src/common/constant/options.ts 里面
|
你好 @xiaochong44，感谢你的贡献, 为了让代码更健壮, 请补充相应单元测试, 如果有API改动, 请修改 相应的文档 Hello, @xiaochong44, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
|
描述里可以关联下 issue #987 |
|
commit 需要 rebase 一下, 请以 |
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
=======================================
Coverage 71.85% 71.85%
=======================================
Files 170 170
Lines 12179 12179
Branches 2868 2869 +1
=======================================
Hits 8751 8751
Misses 2222 2222
Partials 1206 1206
Continue to review full report at Codecov.
|
| */ | ||
| protected initGroups() { | ||
| const { width, height } = this.options; | ||
| const { width, height, supportCSSTransform = false } = this.options; |
5 participants
👀 PR includes
✨ Feature
增加supportCSSTransform设置，解决父元素缩放引起的鼠标定位错乱问题
🎨 Enhance