Skip to content

fix: ts problem#1876

Merged
YardWill merged 7 commits intorefactor-strictfrom
yard/ts
Nov 4, 2022
Merged

fix: ts problem#1876
YardWill merged 7 commits intorefactor-strictfrom
yard/ts

Conversation

@YardWill
Copy link
Copy Markdown
Member

@YardWill YardWill commented Nov 4, 2022

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

嘤嘤嘤 and others added 4 commits November 1, 2022 08:17
* feat: 为合并单元格添加主题

* test: 添加合并单元格主题相关单测
@vercel
Copy link
Copy Markdown

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 0:07AM (UTC)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2022

你好, @YardWill CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复

Hello, @YardWill CI run failed, please click the [Details] button for detailed log information and fix it.

"@swc/jest": "^0.2.23",
"@types/jest": "^27.4.1",
"@types/lodash": "^4.14.182",
"@types/lodash": "4.14.186",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

187版本的@types/lodash的get方法实现有问题,所以先定死在186,已经有相关PR在修复了,等修复完毕后再改箭头

"@types/lodash": "^4.14.182",
"@types/lodash": "4.14.186",
"@types/node": "^17.0.26",
"@types/react": "^17.0.52",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来lock的依赖版本有问题,div下children属性不能是数组,所以这里升级types版本

@YardWill YardWill merged commit 94713e0 into refactor-strict Nov 4, 2022
@YardWill YardWill deleted the yard/ts branch November 4, 2022 12:30
@github-actions github-actions bot removed 🚨 test failed 单元测试挂了 🚨 lint failed 静态检查失败 labels Nov 4, 2022
YardWill added a commit that referenced this pull request Nov 11, 2022
* refactor: 支持 ts 严格模式 close #1742

* fix: 修复部分类型错误

* fix

* fix

* fix: 修复测试

* fix:

* fix: ts problem (#1876)

* docs: update the README.md (#1863)

* fix: 修复 mergedCell 缺失theme 导致的报错 (#1874)

* feat: 为合并单元格添加主题

* test: 添加合并单元格主题相关单测

* chore: 更新README (#1865)

Co-authored-by: Jinke Li <[email protected]>

* fix: ts problem

Co-authored-by: 嘤嘤嘤 <[email protected]>
Co-authored-by: stone <[email protected]>
Co-authored-by: Jinke Li <[email protected]>

* fix: 升级配置

* test: 修复测试

* chore: 修复类型错误

Co-authored-by: YardWill <[email protected]>
Co-authored-by: 嘤嘤嘤 <[email protected]>
Co-authored-by: stone <[email protected]>
@lijinke666
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr(fix) bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants