Skip to content

refactor: 支持 ts 严格模式 close #1742#1859

Merged
YardWill merged 13 commits intonextfrom
refactor-strict
Nov 11, 2022
Merged

refactor: 支持 ts 严格模式 close #1742#1859
YardWill merged 13 commits intonextfrom
refactor-strict

Conversation

@lijinke666
Copy link
Copy Markdown
Member

@lijinke666 lijinke666 commented Oct 27, 2022 •
edited
Loading

👀 PR includes

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

📝 Description

  1. 支持 ts 严格模式, 类型增强
  2. 开发工具升级
    • vite 3 +
    • typescript 4.8 +

🖼️ Screenshot

Before After
❌ ✅

🔗 Related issue link

ref #1735

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
antvis-s2 ❌ Failed (Inspect) Nov 11, 2022 at 9:58AM (UTC)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 27, 2022 •
edited
Loading

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 lint failed 静态检查失败 🚨 test failed 单元测试挂了 labels Oct 27, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Oct 27, 2022

This pull request fixes 3 alerts when merging de38cb5 into a982ff8 - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lijinke666 lijinke666 changed the title [WIP] refactor: 支持 ts 严格模式 close #1742 refactor: 支持 ts 严格模式 close #1742 Nov 3, 2022
@github-actions github-actions bot added the pr(refactor) refactor label Nov 3, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 3, 2022

This pull request fixes 3 alerts when merging dbe700f into db07aca - view on LGTM.com

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 3, 2022

This pull request fixes 5 alerts when merging 3bdf616 into db07aca - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@lijinke666 lijinke666 changed the title refactor: 支持 ts 严格模式 close #1742 [WIP] refactor: 支持 ts 严格模式 close #1742 Nov 8, 2022
@github-actions github-actions bot removed the pr(refactor) refactor label Nov 8, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 11, 2022

This pull request fixes 5 alerts when merging 516b719 into 63e0bd9 - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@lijinke666 lijinke666 changed the title [WIP] refactor: 支持 ts 严格模式 close #1742 refactor: 支持 ts 严格模式 close #1742 Nov 11, 2022
@github-actions github-actions bot added the pr(refactor) refactor label Nov 11, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 11, 2022

This pull request fixes 5 alerts when merging 28dc9ac into 63e0bd9 - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 11, 2022

This pull request fixes 5 alerts when merging b6f91d5 into 63e0bd9 - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@github-actions github-actions bot removed the 🚨 lint failed 静态检查失败 label Nov 11, 2022
@YardWill YardWill merged commit 75fa892 into next Nov 11, 2022
@YardWill YardWill deleted the refactor-strict branch November 11, 2022 10:01
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 11, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 11, 2022

This pull request fixes 5 alerts when merging 1d008e1 into 6ed8892 - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Nov 11, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 11, 2022

Size Change: -14.5 kB (-3%)

Total Size: 419 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 157 kB -13.8 kB (-8%) ✅
./packages/s2-react/dist/index.min.js 65.2 kB -604 B (-1%)
./packages/s2-vue/dist/index.min.js 20.3 kB -156 B (-1%)
./packages/s2-vue/dist/style.min.css 1.79 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/style.min.css 3.53 kB

compressed-size-action

This was referenced Nov 14, 2022
Closed
Closed
@lijinke666
Copy link
Copy Markdown
Member Author

lijinke666 commented Nov 25, 2022

🎉 This PR is included in version @antv/s2-v2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Copy Markdown
Member Author

lijinke666 commented Nov 25, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Copy Markdown
Member Author

lijinke666 commented Nov 25, 2022

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Copy Markdown
Member Author

lijinke666 commented Nov 25, 2022

🎉 This PR is included in version @antv/s2-vue-v2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaoFuhong GaoFuhong Awaiting requested review from GaoFuhong

@lcx-seima lcx-seima Awaiting requested review from lcx-seima

@serializedowen serializedowen Awaiting requested review from serializedowen

@stone-lyl stone-lyl Awaiting requested review from stone-lyl

@wjgogogo wjgogogo Awaiting requested review from wjgogogo

@xingwanying xingwanying Awaiting requested review from xingwanying

@YardWill YardWill Awaiting requested review from YardWill

Assignees

@lijinke666 lijinke666

Labels

pr(refactor) refactor released on @next 🚨 test failed 单元测试挂了

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lijinke666 @YardWill @wjgogogo