fix(facet): scroll speed options & pagination totals by zxc0328 · Pull Request #1031 · antvis/S2

zxc0328 · 2022-01-20T12:32:04Z

👀 PR includes

修复 #1017 中 setOptions 时 scrollSpeedRatio 取值不正确的问题。
修复 #1016 中 React 组件未读取 pagination.total 的问题

🔗 Related issue link

github-actions · 2022-01-20T12:32:18Z

🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-1031.surge.sh

YardWill

LGTM

github-actions · 2022-01-20T12:37:52Z

Size Change: +305 B (0%)

Total Size: 189 kB

Filename	Size	Change
`./packages/s2-core/dist/index.min.js`	118 kB	-114 B (0%)
`./packages/s2-react/dist/index.min.js`	67.9 kB	+419 B (+1%)

ℹ️ View Unchanged

Filename	Size
`./packages/s2-core/dist/style.min.css`	356 B
`./packages/s2-react/dist/style.min.css`	3.1 kB

_{compressed-size-action}

codecov · 2022-01-20T12:57:52Z

Codecov Report

Merging #1031 (358d401) into master (f7ba78f) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
+ Coverage   71.88%   71.92%   +0.04%     
==========================================
  Files         170      170              
  Lines       12243    12243              
  Branches     2884     2884              
==========================================
+ Hits         8801     8806       +5     
+ Misses       2244     2243       -1     
+ Partials     1198     1194       -4

Impacted Files	Coverage Δ
packages/s2-core/src/facet/base-facet.ts	`73.37% <ø> (+0.39%)`	⬆️
packages/s2-core/src/cell/header-cell.ts	`51.94% <0.00%> (+0.48%)`	⬆️
...ckages/s2-core/src/interaction/event-controller.ts	`81.63% <0.00%> (+0.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ba78f...358d401. Read the comment docs.

* chore: 🤖 auto sync site s2 lock and changelog [skip ci] (#1004) * chore(release): 🔖@antv/[email protected] @antv/[email protected] * chore(release): 🔖 @antv/[email protected] @antv/[email protected] * chore(release): 🤖 @antv/s2-v1.3.0 [skip ci] * chore(release): 🤖 @antv/s2-react-v1.3.0 [skip ci] * chore(release): 🔖@antv/[email protected] @antv/[email protected] * chore(release): 🤖 @antv/s2-v1.4.0 [skip ci] * chore(release): 🤖 @antv/s2-react-v1.4.0 [skip ci] * chore(release): 🔖@antv/[email protected] @antv/[email protected] * chore(release): 🤖 @antv/s2-v1.5.0 [skip ci] * chore(release): 🤖 @antv/s2-react-v1.5.0 [skip ci] * chore(release): @antv/[email protected] @antv/[email protected] (#1003) * chore(release): 🤖 @antv/s2-v1.6.0 [skip ci] * chore(release): 🤖 @antv/s2-react-v1.6.0 [skip ci] * chore: 🤖 auto sync site s2 lock and changelog [skip ci] Co-authored-by: yingying.xwy <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: xinhui.zxh <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update base-facet.ts (#1009) 手机端滑动问题修改 * docs: 修复文档404链接和报错demo (#1025) * chore(ci): 新增 prerelease 推送 & CI 细节调整 (#1027) * chore(ci): 新增 prerelease 推送 & ci 细节调整 * chore(ci): 去掉 --ignore-scripts * chore(ci): 去掉 --ignore-scripts * fix(facet): scroll speed options & pagination totals (#1031) * fix: scrollSpeedRatio value * fix: ts err * fix: revert change * fix: pagination total * fix(s2-core): 修复延迟销毁表格时没有移除canvas节点的问题 close #1011 (#1033) * docs: 增加小册子demo《哲学家的观点》 (#1035) * fix(tooltip): 修复单元格文字过长时 tooltip 显示被截断 close #1028 (#1034) * feat: 支持配置前端计算小计/总计 (#921) * feat: surport caculate totals in pivot data set * test: add number calculate and totals calculate test * refactor: change totals type to readonly * refactor: code style * refactor: code style and optimize test * docs: add calcTotals's docs and demos * fix: get cell data * test: table facet test's width * feat: 重构前端计算汇总值 * test: 增加前端计算totals测试 * refactor: 抽离getAggregationAndCalcFuncByQuery到utils * test: 增加getAggregationAndCalcFuncByQuery的测试 * docs: 小计总计文档更新 * fix(tooltip): 修复明细表列头的 tooltip 内容被错误的格式化 close #998 (#1036) * fix(tooltip): 修复明细表列头的 tooltip 内容被错误的格式化 close #998 * chore: 还原 meta * test: 修复测试 * fix(interactive): table move problem (#1013) * fix: table move problem * fix: code * fix: v * fix: move * fix: calculateInViewIndexes * feat: update table facet * fix: v * fix: code 整理 * fix: 修复测试用例 Co-authored-by: xinhui.zxh <[email protected]> * docs: 优化demo《哲学家的观点》 (#1038) * feat: 完善交叉表分页功能 (#1037) * chore: s2-react watch script * fix: maxHeight等于offset数组值时下标返回偏大 * fix(s2react): 交叉表初始化未更新分页total * fix(facet): 序号列无法渲染 * fix(pivotfacet): 渲染行数返回错误 * fix(facet): 按视窗高度剪裁行头和序号列 * fix: 计算文字位置时应使用viewportHeight视窗高度 * fix(facet): rowIndexHeader可能为null * fix(facet): 序号列应早于列头添加到group (#1040) * chore(release): @antv/[email protected] @antv/[email protected] (#1039) * chore(release): @antv/[email protected] @antv/[email protected] (#1039) (#1041) This reverts commit 0d538f2. * chore(release): @antv/[email protected] @antv/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: yingying.xwy <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: xinhui.zxh <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: gehaiyi <[email protected]> Co-authored-by: Jinke Li <[email protected]> Co-authored-by: yangzhanmei <[email protected]> Co-authored-by: 刘嘉一 <[email protected]>

lijinke666 · 2022-01-24T10:55:48Z

🎉 This PR is included in version @antv/s2-v1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2022-01-24T10:58:50Z

🎉 This PR is included in version @antv/s2-react-v1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2022-01-26T04:29:54Z

🎉 This PR is included in version @antv/s2-v1.7.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2022-01-26T04:32:46Z

🎉 This PR is included in version @antv/s2-react-v1.7.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

* fix: scrollSpeedRatio value * fix: ts err * fix: revert change * fix: pagination total

zxc0328 added 2 commits January 20, 2022 20:28

fix: scrollSpeedRatio value

813e198

fix: ts err

f99c439

github-actions bot assigned zxc0328 Jan 20, 2022

github-actions bot added the pr(fix) bug fix label Jan 20, 2022

github-actions bot requested review from YardWill, lijinke666, qubaomingg, stone-lyl, wjgogogo, xingwanying and yangzhanmei January 20, 2022 12:32

fix: revert change

68f8599

YardWill previously approved these changes Jan 20, 2022

View reviewed changes

fix: pagination total

358d401

zxc0328 dismissed YardWill’s stale review via 358d401 January 20, 2022 12:56

zxc0328 changed the title ~~fix(facet): scroll speed options~~ fix(facet): scroll speed options & pagination totals Jan 20, 2022

xingwanying approved these changes Jan 20, 2022

View reviewed changes

xingwanying merged commit 2082c22 into master Jan 20, 2022

xingwanying deleted the fix/scrollspeedOpts branch January 20, 2022 15:24

lijinke666 added the released label Jan 24, 2022

lijinke666 added the released on @alpha label Jan 26, 2022

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023

fix(facet): scroll speed options & pagination totals (#1031)

724ec29

* fix: scrollSpeedRatio value * fix: ts err * fix: revert change * fix: pagination total

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(facet): scroll speed options & pagination totals#1031

fix(facet): scroll speed options & pagination totals#1031
xingwanying merged 4 commits intomasterfrom
fix/scrollspeedOpts

zxc0328 commented Jan 20, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Jan 20, 2022 •

edited

Loading

Uh oh!

YardWill left a comment

Uh oh!

github-actions bot commented Jan 20, 2022 •

edited

Loading

Uh oh!

codecov bot commented Jan 20, 2022 •

edited

Loading

Uh oh!

lijinke666 commented Jan 24, 2022

Uh oh!

lijinke666 commented Jan 24, 2022

Uh oh!

lijinke666 commented Jan 26, 2022

Uh oh!

lijinke666 commented Jan 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zxc0328 commented Jan 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👀 PR includes

🔗 Related issue link

Uh oh!

github-actions bot commented Jan 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YardWill left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lijinke666 commented Jan 24, 2022

Uh oh!

lijinke666 commented Jan 24, 2022

Uh oh!

lijinke666 commented Jan 26, 2022

Uh oh!

lijinke666 commented Jan 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zxc0328 commented Jan 20, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022 •

edited

Loading

github-actions bot commented Jan 20, 2022 •

edited

Loading

codecov bot commented Jan 20, 2022 •

edited

Loading