Skip to content

fix(interactive): table move problem#1013

Merged
YardWill merged 9 commits intomasterfrom
move-fix
Jan 24, 2022
Merged

fix(interactive): table move problem#1013
YardWill merged 9 commits intomasterfrom
move-fix

Conversation

@YardWill
Copy link
Copy Markdown
Member

@YardWill YardWill commented Jan 18, 2022

👀 PR includes

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

📝 Description

重写scrollToActiveCell方法,滚动效果和excel保持一致

🖼️ Screenshot

Screen.Recording.2022-01-24.at.11.19.58.AM.mov

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 18, 2022

🎊 PR Preview has been successfully built and deployed to https://s2-preview-pr-1013.surge.sh

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 18, 2022

Size Change: +153 B (0%)

Total Size: 189 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 118 kB +46 B (0%)
./packages/s2-core/dist/style.min.css 362 B +6 B (+2%)
./packages/s2-react/dist/index.min.js 67.9 kB +429 B (+1%)
./packages/s2-react/dist/style.min.css 2.77 kB -328 B (-11%) 👏

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1013 (796f37d) into master (8b37d47) will increase coverage by 0.21%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   71.88%   72.09%   +0.21%     
==========================================
  Files         170      170              
  Lines       12243    12290      +47     
  Branches     2884     2898      +14     
==========================================
+ Hits         8801     8861      +60     
+ Misses       2244     2232      -12     
+ Partials     1198     1197       -1     
Impacted Files Coverage Δ
packages/s2-core/src/facet/table-facet.ts 82.00% <ø> (ø)
packages/s2-core/src/facet/utils.ts 79.85% <75.00%> (ø)
packages/s2-core/src/facet/base-facet.ts 72.97% <80.00%> (ø)
...ages/s2-core/src/interaction/selected-cell-move.ts 79.48% <82.60%> (+3.34%) ⬆️
packages/s2-core/src/sheet-type/spread-sheet.ts 81.41% <0.00%> (+0.54%) ⬆️
packages/s2-core/src/facet/header/corner.ts 79.24% <0.00%> (+2.51%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b37d47...796f37d. Read the comment docs.

@YardWill YardWill changed the title fix(interactive): table move problem WIP fix(interactive): table move problem Jan 18, 2022
@github-actions github-actions bot removed the pr(fix) bug fix label Jan 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 20, 2022

你好, @YardWill CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @YardWill CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jan 20, 2022
@YardWill YardWill changed the title WIP fix(interactive): table move problem fix(interactive): table move problem Jan 24, 2022
@github-actions github-actions bot added the pr(fix) bug fix label Jan 24, 2022
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Jan 24, 2022
Copy link
Copy Markdown
Member

@zxc0328 zxc0328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@YardWill YardWill merged commit f73a1c9 into master Jan 24, 2022
@YardWill YardWill deleted the move-fix branch January 24, 2022 05:58
YardWill added a commit that referenced this pull request Jan 24, 2022
* chore: 🤖 auto sync site s2 lock and changelog [skip ci] (#1004)

* chore(release): 🔖@antv/[email protected]  @antv/[email protected]

* chore(release): 🔖 @antv/[email protected]  @antv/[email protected]

* chore(release): 🤖 @antv/s2-v1.3.0 [skip ci]

* chore(release): 🤖 @antv/s2-react-v1.3.0 [skip ci]

* chore(release): 🔖@antv/[email protected] @antv/[email protected]

* chore(release): 🤖 @antv/s2-v1.4.0 [skip ci]

* chore(release): 🤖 @antv/s2-react-v1.4.0 [skip ci]

* chore(release): 🔖@antv/[email protected] @antv/[email protected]

* chore(release): 🤖 @antv/s2-v1.5.0 [skip ci]

* chore(release): 🤖 @antv/s2-react-v1.5.0 [skip ci]

* chore(release): @antv/[email protected] @antv/[email protected] (#1003)

* chore(release): 🤖 @antv/s2-v1.6.0 [skip ci]

* chore(release): 🤖 @antv/s2-react-v1.6.0 [skip ci]

* chore: 🤖 auto sync site s2 lock and changelog [skip ci]

Co-authored-by: yingying.xwy <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: xinhui.zxh <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update base-facet.ts (#1009)

手机端滑动问题修改

* docs: 修复文档404链接和报错demo (#1025)

* chore(ci): 新增 prerelease 推送 & CI 细节调整 (#1027)

* chore(ci): 新增 prerelease 推送 & ci 细节调整

* chore(ci): 去掉 --ignore-scripts

* chore(ci): 去掉 --ignore-scripts

* fix(facet): scroll speed options & pagination totals (#1031)

* fix: scrollSpeedRatio value

* fix: ts err

* fix: revert change

* fix: pagination total

* fix(s2-core): 修复延迟销毁表格时没有移除canvas节点的问题 close #1011 (#1033)

* docs: 增加小册子demo《哲学家的观点》 (#1035)

* fix(tooltip): 修复单元格文字过长时 tooltip 显示被截断 close #1028 (#1034)

* feat: 支持配置前端计算小计/总计 (#921)

* feat: surport caculate totals in pivot data set

* test: add number calculate and totals calculate test

* refactor: change totals type to readonly

* refactor: code style

* refactor: code style and optimize test

* docs: add calcTotals's docs and demos

* fix: get cell data

* test: table facet test's width

* feat: 重构前端计算汇总值

* test: 增加前端计算totals测试

* refactor: 抽离getAggregationAndCalcFuncByQuery到utils

* test: 增加getAggregationAndCalcFuncByQuery的测试

* docs: 小计总计文档更新

* fix(tooltip): 修复明细表列头的 tooltip 内容被错误的格式化 close #998 (#1036)

* fix(tooltip): 修复明细表列头的 tooltip 内容被错误的格式化 close #998

* chore: 还原 meta

* test: 修复测试

* fix(interactive): table move problem (#1013)

* fix: table move problem

* fix: code

* fix: v

* fix: move

* fix: calculateInViewIndexes

* feat: update table facet

* fix: v

* fix: code 整理

* fix: 修复测试用例

Co-authored-by: xinhui.zxh <[email protected]>

* docs: 优化demo《哲学家的观点》 (#1038)

* feat: 完善交叉表分页功能 (#1037)

* chore: s2-react watch script

* fix: maxHeight等于offset数组值时下标返回偏大

* fix(s2react): 交叉表初始化未更新分页total

* fix(facet): 序号列无法渲染

* fix(pivotfacet): 渲染行数返回错误

* fix(facet): 按视窗高度剪裁行头和序号列

* fix: 计算文字位置时应使用viewportHeight视窗高度

* fix(facet): rowIndexHeader可能为null

* fix(facet): 序号列应早于列头添加到group (#1040)

* chore(release): @antv/[email protected] @antv/[email protected] (#1039)

* chore(release): @antv/[email protected] @antv/[email protected] (#1039) (#1041)

This reverts commit 0d538f2.

* chore(release): @antv/[email protected] @antv/[email protected]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: yingying.xwy <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: xinhui.zxh <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: gehaiyi <[email protected]>
Co-authored-by: Jinke Li <[email protected]>
Co-authored-by: yangzhanmei <[email protected]>
Co-authored-by: 刘嘉一 <[email protected]>
@lijinke666
Copy link
Copy Markdown
Member

🎉 This PR is included in version @antv/s2-v1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Copy Markdown
Member

🎉 This PR is included in version @antv/s2-v1.7.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

wjgogogo pushed a commit that referenced this pull request Oct 25, 2023
* fix: table move problem

* fix: code

* fix: v

* fix: move

* fix: calculateInViewIndexes

* feat: update table facet

* fix: v

* fix: code 整理

* fix: 修复测试用例

Co-authored-by: xinhui.zxh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants