Skip to content

Commit dc7a9f6

Browse files
committed
test: 修复测试
1 parent 1008400 commit dc7a9f6

File tree

4 files changed

+32
-29
lines changed

4 files changed

+32
-29
lines changed

packages/s2-core/__tests__/unit/facet/table-facet-spec.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,12 @@ describe('Table Mode Facet Test With Adaptive Layout', () => {
127127
});
128128

129129
describe('should get correct col layout with seriesNumber', () => {
130-
const ss: SpreadSheet = new MockSpreadSheet();
131-
const dataSet: TableDataSet = new MockTableDataSet(ss);
130+
const s2: SpreadSheet = new MockSpreadSheet();
131+
const s2DataSet: TableDataSet = new MockTableDataSet(s2);
132132
const facet = new TableFacet({
133133
...options,
134-
spreadsheet: ss,
135-
dataSet,
134+
spreadsheet: s2,
135+
dataSet: s2DataSet,
136136
showSeriesNumber: true,
137137
});
138138
const { colCfg, cellCfg } = facet.cfg;
@@ -151,12 +151,12 @@ describe('Table Mode Facet Test With Adaptive Layout', () => {
151151
const seriesNumberNode = colLeafNodes[0];
152152
expect(seriesNumberNode.y).toBe(0);
153153
expect(seriesNumberNode.x).toBe(0);
154-
// expect(seriesNumberNode.width).toBe(seriesNumberWidth);
154+
expect(seriesNumberNode.width).toBe(seriesNumberWidth);
155155
expect(seriesNumberNode.height).toBe(colCfg.height);
156156

157157
colLeafNodes.slice(1).forEach((node, index) => {
158158
expect(node.y).toBe(0);
159-
// expect(node.x).toBe(index * adaptiveWith + seriesNumberWidth);
159+
expect(node.x).toBe(index * adaptiveWith + seriesNumberWidth);
160160
expect(node.width).toBe(adaptiveWith);
161161
expect(node.height).toBe(colCfg.height);
162162
});
@@ -217,7 +217,7 @@ describe('Table Mode Facet Test With Compact Layout', () => {
217217
test('col hierarchy coordinate with compact layout with seriesNumber', () => {
218218
const { colLeafNodes } = facet.layoutResult;
219219

220-
const COMPACT_WIDTH = [52, 52, 64, 40, 72.765625];
220+
const COMPACT_WIDTH = [80, 52, 52, 64, 40, 72.765625];
221221

222222
let lastX = 0;
223223
colLeafNodes.forEach((node, index) => {

packages/s2-core/__tests__/unit/utils/export/copy-spec.ts

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { TableSheet } from 'src/sheet-type';
2-
import { assembleDataCfg, assembleOptions } from '../../../util';
3-
import { getContainer } from '../../../util/helpers';
4-
import { data as originalData } from '../../../data/mock-dataset.json';
5-
2+
import { assembleDataCfg, assembleOptions } from 'tests/util';
3+
import { getContainer } from 'tests/util/helpers';
4+
import { data as originalData } from 'tests/data/mock-dataset.json';
65
import {
76
CellTypes,
87
InteractionStateName,
@@ -13,19 +12,26 @@ import { getCellMeta } from '@/utils/interaction/select-event';
1312
import { S2Event } from '@/common/constant';
1413

1514
describe('List Table Core Data Process', () => {
16-
const s2 = new TableSheet(
17-
getContainer(),
18-
assembleDataCfg({
19-
meta: [],
20-
fields: {
21-
columns: ['province', 'city', 'type', 'sub_type', 'number'],
22-
},
23-
}),
24-
assembleOptions({
25-
showSeriesNumber: true,
26-
}),
27-
);
28-
s2.render();
15+
let s2: TableSheet;
16+
beforeEach(() => {
17+
s2 = new TableSheet(
18+
getContainer(),
19+
assembleDataCfg({
20+
meta: [],
21+
fields: {
22+
columns: ['province', 'city', 'type', 'sub_type', 'number'],
23+
},
24+
}),
25+
assembleOptions({
26+
showSeriesNumber: true,
27+
}),
28+
);
29+
s2.render();
30+
});
31+
32+
afterEach(() => {
33+
s2.destroy();
34+
});
2935

3036
it('should copy no data', () => {
3137
s2.interaction.changeState({
@@ -73,9 +79,6 @@ describe('List Table Core Data Process', () => {
7379
});
7480

7581
it('should copy all data', () => {
76-
const cell = s2.interaction
77-
.getAllCells()
78-
.filter(({ cellType }) => cellType === CellTypes.ROW_CELL)[3];
7982
s2.interaction.changeState({
8083
stateName: InteractionStateName.ALL_SELECTED,
8184
});

packages/s2-core/__tests__/unit/utils/merge-spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
getSafetyDataConfig,
55
getSafetyOptions,
66
} from '@/utils/merge';
7-
import type { S2DataConfig, S2Options } from '@/common';
7+
import type { S2DataConfig } from '@/common';
88

99
describe('merge test', () => {
1010
test('should replace old array with new one', () => {

packages/s2-core/src/facet/layout/build-table-hierarchy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export const buildTableHierarchy = (params: TableHeaderParams) => {
99
const { columns, spreadsheet, dataSet } = facetCfg;
1010

1111
const hiddenColumnsDetail = spreadsheet.store.get('hiddenColumnsDetail');
12-
const showSeriesNumber = spreadsheet.options?.showSeriesNumber;
12+
const showSeriesNumber = facetCfg?.showSeriesNumber;
1313

1414
const displayedColumns = columns.filter((column) => {
1515
if (!hiddenColumnsDetail) {

0 commit comments

Comments
 (0)