Skip to content

Commit b922fad

Browse files
author
嘤嘤嘤
authored
refactor: 删除无用的 debounceRenderCell 方法 (#1402)
1 parent cfd5dbe commit b922fad

File tree

1 file changed

+3
-19
lines changed

1 file changed

+3
-19
lines changed

packages/s2-core/src/facet/base-facet.ts

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ export abstract class BaseFacet {
194194
this.renderHeaders();
195195
this.renderScrollBars();
196196
this.renderBackground();
197-
this.dynamicRenderCell(false);
197+
this.dynamicRenderCell();
198198
}
199199

200200
/**
@@ -971,15 +971,6 @@ export abstract class BaseFacet {
971971
this.preCellIndexes = indexes;
972972
};
973973

974-
/**
975-
* How long about the delay period, need be re-considered,
976-
* for now only delay, oppose to immediately
977-
* @private
978-
*/
979-
debounceRenderCell = (scrollX: number, scrollY: number) => {
980-
this.realCellRender(scrollX, scrollY);
981-
};
982-
983974
protected init() {
984975
// layout
985976
DebuggerUtil.getInstance().debugCallback(DEBUG_HEADER_LAYOUT, () => {
@@ -995,7 +986,6 @@ export abstract class BaseFacet {
995986
this.calculateCellWidthHeight();
996987
this.calculateCornerBBox();
997988
this.calculatePanelBBox();
998-
999989
this.clipPanelGroup();
1000990
this.bindEvents();
1001991
}
@@ -1183,10 +1173,9 @@ export abstract class BaseFacet {
11831173
/**
11841174
* When scroll behavior happened, only render one time in a period,
11851175
* but render immediately in initiate
1186-
* @param delay debounce render cell
11871176
* @protected
11881177
*/
1189-
protected dynamicRenderCell(delay = true) {
1178+
protected dynamicRenderCell() {
11901179
const { scrollX, scrollY: sy, hRowScrollX } = this.getScrollOffset();
11911180
let scrollY = sy + this.getPaginationScrollY();
11921181

@@ -1196,12 +1185,7 @@ export abstract class BaseFacet {
11961185
this.panelBBox.viewportHeight,
11971186
);
11981187

1199-
if (delay) {
1200-
this.debounceRenderCell(scrollX, scrollY);
1201-
} else {
1202-
this.realCellRender(scrollX, scrollY);
1203-
}
1204-
1188+
this.realCellRender(scrollX, scrollY);
12051189
this.drawGrid();
12061190
this.translateRelatedGroups(scrollX, scrollY, hRowScrollX);
12071191
this.clip(scrollX, scrollY);

0 commit comments

Comments
 (0)