Fix: Preserve offer code discount for installments when code is deleted/expired/maxed (#1410) by yashranaway · Pull Request #3066 · antiwork/gumroad

yashranaway · 2026-01-23T16:14:04Z

Issue: #1410

Description

Problem

When an offer code hits its max usage limit (or gets deleted/expires) between installment charges, subsequent payments lose the discount even though the customer legitimately used the code on their first payment.

Solution

Instead of checking the live offer code on each charge, we now copy the discount data from the original purchase's purchase_offer_code_discount record. This data was already being stored - we just weren't using it for subsequent charges.

Two changes:

Subscription#build_purchase - copies cached discount data to new purchases
Purchase#original_offer_code - prioritizes cached data over live offer code lookup

Test Results

Added tests for:

Deleted offer codes (installments + memberships)
Expired offer codes
Max usage reached
Offer code amount changed after purchase
Percentage discounts
Backwards compatibility with legacy purchases

Checklist

I have read the contributing guidelines
I have watched Gumroad PR review livestreams
I have performed a self-review and left review comments on my PR
I have added/updated tests for my changes

AI Disclosure

Claude Opus 4.5 was used via Claude Code was used for implementation and test writing.

…leted/expired/maxed

yashranaway · 2026-01-23T16:17:45Z

+    if discount_applies_to_next_charge?
+      if original_purchase.purchase_offer_code_discount.present?
+        original_discount = original_purchase.purchase_offer_code_discount
+        purchase.offer_code = original_purchase.offer_code
+        purchase.build_purchase_offer_code_discount(
+          offer_code: original_discount.offer_code,
+          offer_code_amount: original_discount.offer_code_amount,
+          offer_code_is_percent: original_discount.offer_code_is_percent,
+          pre_discount_minimum_price_cents: original_discount.pre_discount_minimum_price_cents,
+          duration_in_months: original_discount.duration_in_months
+        )
+      elsif original_purchase.offer_code.present?
+        purchase.offer_code = original_purchase.offer_code
+      end
+    end


This is the Core fix - we check if original_purchase.purchase_offer_code_discount exists and copy all fields to the new purchase. Falls back to live offer code for legacy purchases that don't have cached data.

yashranaway · 2026-01-23T16:18:55Z

-    return nil if offer_code&.deleted? && !include_deleted
-
    if has_cached_offer_code?
-      code = purchase_offer_code_discount.offer_code.code
+      code = purchase_offer_code_discount.offer_code&.code
      purchase_offer_code_discount.offer_code_is_percent ?
        OfferCode.new(amount_percentage: purchase_offer_code_discount.offer_code_amount, code:) :
        OfferCode.new(amount_cents: purchase_offer_code_discount.offer_code_amount, code:)
+    elsif offer_code&.deleted? && !include_deleted
+      nil


Reordered the logic - check cached data first, then check if offer code is deleted. Previously we'd return nil for deleted codes before even checking if we had cached data.

yashranaway · 2026-01-23T16:19:09Z

This test directly covers the reported issue #1410 - offer code with max_purchase_count=1, verify quantity_left <= 0 after first purchase, then confirm discount still applies to next installment.

yashranaway · 2026-01-23T16:21:07Z

+    if discount_applies_to_next_charge?
+      if original_purchase.purchase_offer_code_discount.present?
+        original_discount = original_purchase.purchase_offer_code_discount
+        purchase.offer_code = original_purchase.offer_code


Setting purchase.offer_code even when it might be nil/deleted - this is intentional for audit trail, the actual discount comes from the cached data.

yashranaway · 2026-01-23T16:24:21Z

@EmCousin _a Hey, I have updated the logic as per previous discussion #2257 (comment). Could you please review?

yashranaway · 2026-02-01T15:21:52Z

@EmCousin light ping on this.

slavingia · 2026-02-11T01:18:52Z

@EmCousin please review or reassign. @ershad bottleneck to examine?

…istence-simplified # Conflicts: # spec/models/subscription_spec.rb

…tion Non-first installment payments should not decrement the offer code's max purchase count or fail offer code validation when the code has been deleted/expired/exhausted after the initial purchase.

…b.com/yashranaway/gumroad into fix/offer-code-persistence-simplified-v2

EmCousin

Thanks @yashranaway - non-first installment payments should not decrement the offer code's max purchase count or fail offer code validation when the code has been deleted/expired/exhausted after the initial purchase. I've added the modifications myself, other than that, the PR looks sound.

Let's run CI.

yashranaway · 2026-02-11T12:02:11Z

@EmCousin Thanks for the additions! Makes sense, I have pushed the fixes for failing tests could you run CI once?

yashranaway · 2026-02-11T12:36:51Z

@EmCousin 2 flaky UI tests (tiered_membership_offer_codes_spec, payments settings/tax scenarios) and 3 Docker infra timeouts (Wait for services timed out).

yashranaway · 2026-02-11T12:54:30Z

@EmCousin Last 1 failing added fix,

yashranaway · 2026-02-11T14:17:51Z

@EmCousin 3 flaky UI tests (Circle integration, US sales tax, payout settings) All related tests pass!

EmCousin

Thanks @yashranaway!

Fix offer code discount persistence for installments when code is de…

52a8bbd

…leted/expired/maxed

yashranaway had a problem deploying to ci-protected January 23, 2026 16:14 — with GitHub Actions Error

fix

6ee718f

yashranaway had a problem deploying to ci-protected January 23, 2026 16:16 — with GitHub Actions Error

yashranaway commented Jan 23, 2026

View reviewed changes

neetogit-bot Bot assigned EmCousin Jan 23, 2026

Merge branch 'main' into fix/offer-code-persistence-simplified

77675c8

yashranaway had a problem deploying to ci-protected January 25, 2026 20:15 — with GitHub Actions Error

Merge branch 'main' into fix/offer-code-persistence-simplified

ffb4525

yashranaway had a problem deploying to ci-protected January 28, 2026 09:37 — with GitHub Actions Error

Merge branch 'main' into fix/offer-code-persistence-simplified

bcc4d1a

yashranaway had a problem deploying to ci-protected February 1, 2026 15:21 — with GitHub Actions Error

sangokp mentioned this pull request Feb 10, 2026

Fix offer code discount not applied to subsequent installments #3498

Closed

7 tasks done

Merge remote-tracking branch 'upstream/main' into fix/offer-code-pers…

a90b781

…istence-simplified # Conflicts: # spec/models/subscription_spec.rb

yashranaway had a problem deploying to ci-protected February 11, 2026 09:05 — with GitHub Actions Error

Exclude non-first installments from offer code usage count and valida…

1e767cd

…tion Non-first installment payments should not decrement the offer code's max purchase count or fail offer code validation when the code has been deleted/expired/exhausted after the initial purchase.

EmCousin had a problem deploying to ci-protected February 11, 2026 10:46 — with GitHub Actions Error

Merge branch 'main' into fix/offer-code-persistence-simplified

19504f0

EmCousin had a problem deploying to ci-protected February 11, 2026 10:48 — with GitHub Actions Error

[autofix.ci] apply automated fixes

4bfc804

autofix-ci Bot had a problem deploying to ci-protected February 11, 2026 10:57 Error

EmCousin added 2 commits February 11, 2026 12:00

rubocop

d732b63

Merge branch 'fix/offer-code-persistence-simplified' of https://githu…

48d1cb4

…b.com/yashranaway/gumroad into fix/offer-code-persistence-simplified-v2

EmCousin had a problem deploying to ci-protected February 11, 2026 11:00 — with GitHub Actions Error

EmCousin reviewed Feb 11, 2026

View reviewed changes

test fixes

8de8441

yashranaway had a problem deploying to ci-protected February 11, 2026 12:01 — with GitHub Actions Error

Merge branch 'main' into fix/offer-code-persistence-simplified

a1a92c1

EmCousin had a problem deploying to ci-protected February 11, 2026 12:13 — with GitHub Actions Error

Revert original_offer_code to respect deleted status

64b6258

yashranaway had a problem deploying to ci-protected February 11, 2026 12:54 — with GitHub Actions Failure

EmCousin approved these changes Feb 11, 2026

View reviewed changes

EmCousin merged commit b9c7979 into antiwork:main Feb 11, 2026
307 of 323 checks passed

yashranaway deleted the fix/offer-code-persistence-simplified branch February 11, 2026 15:33

EmCousin mentioned this pull request Feb 11, 2026

fix(purchase): ensure offer code persistence on installments even if … #3356

Closed

4 tasks done

gianfrancopiana mentioned this pull request Jun 19, 2026

Keep installment plan discounts after the offer code is deleted #5528

Merged

Conversation

yashranaway commented Jan 23, 2026

Description

Problem

Solution

Test Results

Checklist

AI Disclosure

Uh oh!

yashranaway Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

yashranaway Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

yashranaway Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

yashranaway Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

yashranaway commented Jan 23, 2026

Uh oh!

yashranaway commented Feb 1, 2026

Uh oh!

slavingia commented Feb 11, 2026

Uh oh!

EmCousin left a comment

Choose a reason for hiding this comment

Uh oh!

yashranaway commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yashranaway commented Feb 11, 2026

Uh oh!

yashranaway commented Feb 11, 2026

Uh oh!

yashranaway commented Feb 11, 2026

Uh oh!

EmCousin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yashranaway commented Feb 11, 2026 •

edited

Loading