Migrate payouts by yashranaway · Pull Request #2384 · antiwork/gumroad

yashranaway · 2025-12-17T11:29:17Z

Part of https://github.com/antiwork/gumroad/issues/856
Previous PR: #2383

This PR migrates the following page to Inertia:

/payouts

Before

After

(No visual changes)

Screen.Recording.2025-12-17.at.2.33.44.PM.mov

Without Data

Tests

AI disclosure

Used Claude Sonnet 4.5 for implementation and tests
All code manually reviewed by me

Confirmation

I have watched all Antiwork Livestreams

…e flash messages

yashranaway

hey @EmCousin, Updated the PR to now use router.reload with InertiaRails.merge , updated tests, All pass! Could you please review again?

yashranaway · 2025-12-17T11:43:28Z

+           props: {
+             payout_presenter: payout_props.except(:past_payout_period_data, :pagination),
+             past_payout_period_data: InertiaRails.merge { payout_props[:past_payout_period_data] },
+             pagination: payout_props[:pagination]
+           }


Uses InertiaRails.merge to append new page data to existing list on frontend

yashranaway · 2025-12-17T11:46:14Z

+  const loadNextPage = () => {
+    router.reload({
+      data: { page: pagination.page + 1 },
+      only: ["past_payout_period_data", "pagination"],
+    });
+  };


Partial reload to trigger server-side merging of past_payout_period_data

yashranaway · 2025-12-17T11:47:47Z

+        expect(response).to be_successful
+        expect(inertia.props[:past_payout_period_data]).to be_an(Array)
+        expect(inertia.props[:past_payout_period_data].length).to eq(payments_per_page)
+      end


Verifies that InertiaRails.merge correctly handles the data for infinite scroll

EmCousin

It's close to merging, so not closing - can you address the comment below? 👇

yashranaway · 2025-12-17T14:00:13Z

@EmCousin _a Updated, Separated payout and pagination concerns and also updated the spec.

EmCousin · 2025-12-18T15:57:43Z

@yashranaway can you fix the failing tests?

yashranaway · 2025-12-18T17:31:49Z

@EmCousin Done, Could you trigger CI ? thanks :)

yashranaway · 2025-12-24T16:08:26Z

@EmCousin I’m blocked on getting the test suite to run locally despite multiple attempts. Since the core changes are already approved by you, would you be able to take over and help?

If that’s easier, I’m fine closing the PR and letting someone else attempt.

only with #2395 🙏 , managed for #2384 sorry for the confustion

yashranaway · 2025-12-24T19:30:28Z

Update : The failing tests are not related, added a commit to fix the Lints. Good to merge this PR!
cc: @EmCousin _a

EmCousin · 2025-12-24T20:44:53Z

Thanks @yashranaway, I'll take a look next week as I'm AFK until Dec 29 🙏

yashranaway · 2025-12-24T20:46:33Z

Sorry about the hassle and thanks to you, happy holidays @EmCousin ❤️

yashranaway · 2025-12-29T10:09:02Z

@EmCousin can you please trigger CI again

yashranaway · 2025-12-29T10:52:26Z

@EmCousin All tests passing, the 2 fails are unrelated!

EmCousin

Didn't see it in my last review; I'll help you implement those changes

EmCousin · 2025-12-29T13:18:30Z

pagination state should now derive from the props directly

EmCousin · 2025-12-29T13:27:22Z

No, the whole point of letting Inertia handling the props merging is to no longer to have this code at all.
A simple router.reload({ data: { page: pagination.next } }) should be doing the job here

router.reload({ data: { page: pagination.next }, only: ["pagination", "payouts"], onStart: () => setIsLoading(true), onFinish: () => setIsLoading(false), })

EmCousin · 2025-12-29T13:32:25Z

-      pagination:
-    }
+           props: {
+             payout_presenter: payout_presenter.payout_props,


We should expose the payout props directly and not create extra nesting here.

EmCousin · 2025-12-29T13:37:26Z

@@ -19,26 +19,15 @@ def index
      next_payout_period_data: seller_stats[:next_payout_period_data],


next_payout_period_data should be fetched only when necessary. Right now it is always evaluated when hitting this endpoint. That means when performing a partial reload to retrieve the next page of past payouts, this code is executed although it is not used in the frontend. It needs to be moved to a separate method and invoked from within a lambda to benefit from lazy data evaluation

EmCousin · 2025-12-29T13:37:50Z

@@ -19,26 +19,15 @@ def index
      next_payout_period_data: seller_stats[:next_payout_period_data],
      processing_payout_periods_data: seller_stats[:processing_payout_periods_data],


Same comment for processing_payout_periods_data

EmCousin · 2025-12-29T13:39:24Z

      processing_payout_periods_data: seller_stats[:processing_payout_periods_data],
      seller: current_seller,
-      pagination:,
      past_payouts:


Same comment for past_payouts

yashranaway · 2025-12-29T13:47:58Z

Didn't see it in my last review; I'll help you implement those changes

Should I start addressing those changes?

EmCousin · 2025-12-29T13:51:47Z

@yashranaway yes

yashranaway · 2025-12-29T14:22:50Z

@EmCousin Addressed all the changes, Can you review?

yashranaway · 2025-12-30T14:59:11Z

@EmCousin autofix 😅

yashranaway · 2025-12-30T15:51:01Z

@EmCousin All tests pass! The failing test seems unrelated.

yashranaway · 2025-12-30T16:51:24Z

Same test failed, should I try fixing it?

EmCousin

Thanks @yashranaway !

yashranaway and others added 5 commits December 17, 2025 13:15

Migrate Payouts instant payout to Inertia router.post with server-sid…

ee09013

…e flash messages

Update instant payouts controller tests for Inertia redirect pattern

aa1859e

Merge branch 'main' into migrate-payouts

87ff2ae

Refactor Payouts pagination to use InertiaRails.merge with router.reload

0f90498

Merge branch 'main' into migrate-payouts

551527b

yashranaway commented Dec 17, 2025

View reviewed changes

yashranaway marked this pull request as ready for review December 17, 2025 11:49

EmCousin suggested changes Dec 17, 2025

View reviewed changes

Comment thread app/controllers/balance_controller.rb Resolved

EmCousin assigned yashranaway Dec 17, 2025

fix

c1e4c09

neetogit-bot Bot assigned EmCousin and unassigned yashranaway Dec 17, 2025

yashranaway and others added 2 commits December 17, 2025 23:01

Merge branch 'main' into migrate-payouts

571f347

Merge branch 'main' into migrate-payouts

4d73614

yashranaway and others added 2 commits December 18, 2025 23:00

fix: use balance_path for pagination

5c8d368

Merge branch 'main' into migrate-payouts

380b093

yashranaway and others added 4 commits December 19, 2025 23:56

Merge branch 'main' into migrate-payouts

35c5962

Merge branch 'main' into migrate-payouts

4a7a308

Merge branch 'main' into migrate-payouts

7a216f9

Merge branch 'main' into migrate-payouts

7c73300

neetogit-bot Bot added the working Someone is actively working this — don't duplicate effort label Dec 24, 2025

yashranaway added 2 commits December 25, 2025 00:57

Fix ESLint type assertion errors in Payouts/Index.tsx

770da55

better fix

47b64e7

EmCousin and others added 2 commits December 29, 2025 10:20

Merge branch 'main' into migrate-payouts

9c02df9

[autofix.ci] apply automated fixes

bde3e6e

EmCousin suggested changes Dec 29, 2025

View reviewed changes

review fixes

92c722b

EmCousin and others added 3 commits December 30, 2025 15:52

move presentation logic back to the presenter

3c1cb03

Merge branch 'main' into migrate-payouts

c4fabcc

[autofix.ci] apply automated fixes

01219d1

Merge branch 'main' into migrate-payouts

1353709

Merge branch 'main' into migrate-payouts

1141111

yashranaway and others added 3 commits December 30, 2025 22:25

Merge branch 'main' into migrate-payouts

75e621a

Merge branch 'main' into migrate-payouts

513fb42

Merge branch 'main' into migrate-payouts

e497605

EmCousin approved these changes Dec 31, 2025

View reviewed changes

EmCousin merged commit 2caf1d9 into antiwork:main Dec 31, 2025
65 checks passed

		@@ -19,26 +19,15 @@ def index
		next_payout_period_data: seller_stats[:next_payout_period_data],

		@@ -19,26 +19,15 @@ def index
		next_payout_period_data: seller_stats[:next_payout_period_data],
		processing_payout_periods_data: seller_stats[:processing_payout_periods_data],

Conversation

yashranaway commented Dec 17, 2025

Before

After

Without Data

Tests

AI disclosure

Confirmation

Uh oh!

yashranaway left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EmCousin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yashranaway commented Dec 17, 2025

Uh oh!

EmCousin commented Dec 18, 2025

Uh oh!

yashranaway commented Dec 18, 2025

Uh oh!

yashranaway commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yashranaway commented Dec 24, 2025

Uh oh!

EmCousin commented Dec 24, 2025

Uh oh!

yashranaway commented Dec 24, 2025

Uh oh!

yashranaway commented Dec 29, 2025

Uh oh!

yashranaway commented Dec 29, 2025

Uh oh!

EmCousin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashranaway commented Dec 29, 2025

Uh oh!

EmCousin commented Dec 29, 2025

Uh oh!

yashranaway commented Dec 29, 2025

Uh oh!

yashranaway commented Dec 30, 2025

Uh oh!

yashranaway commented Dec 30, 2025

Uh oh!

yashranaway commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EmCousin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

yashranaway commented Dec 24, 2025 •

edited

Loading

yashranaway commented Dec 30, 2025 •

edited

Loading