Repository navigation
Conversation
The consolidation onto src/entrypoints/run.ts left three unreferenced items behind. Each is confirmed to have no importer or caller in src/ or test/: - src/entrypoints/prepare.ts: an orphaned parallel copy of the prepare phase. action.yml invokes only run.ts / cleanup-ssh-signing.ts / post-buffered-inline-comments.ts. Nothing imports it, so a prepare-phase bug 'fixed' here would have no runtime effect while silently drifting from run.ts. - src/github/operations/comments/update-with-branch.ts: exports only updateTrackingComment, which has no callers; the branch-link behaviour is now handled by updateCommentLink. The file is imported nowhere, so it is removed. - checkTriggerAction in src/github/validation/trigger.ts: a thin wrapper with no callers (run.ts calls checkContainsTrigger directly). Removing it makes the '@actions/core' import unused, so that is dropped too. No behaviour change. Closes anthropics#1668
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.0 consolidation onto
src/entrypoints/run.tsleft three unreferenced items behind. Each is confirmed to have no importer or caller insrc/ortest/on current main:src/entrypoints/prepare.tsaction.ymlinvokes onlyrun.ts,cleanup-ssh-signing.ts,post-buffered-inline-comments.ts. A prepare-phase bug "fixed" here has no runtime effect while drifting silently fromrun.ts.src/github/operations/comments/update-with-branch.tsupdateTrackingComment, which has no callers; the branch-link behaviour is now handled byupdateCommentLink. File imported nowhere → removed.checkTriggerActioninsrc/github/validation/trigger.tsrun.tscallscheckContainsTriggerdirectly). Removing it makes the@actions/coreimport unused, so that is dropped too.Verification
bun run prettier --checkon the edited file — cleantest/trigger-validation.test.ts— 27 pass, 0 failNo behaviour change. Closes #1668