Repository navigation
Conversation
…action-references
Remap runningTurnSends using the same map as the written transcript. Trim lists for records deliberately excluded by a cutoff or sidechain/ progress filtering, and drop blocks whose required endpoint was excluded. Preserve historical IDs absent from the source and uninterpreted metadata. Add public disk/store regressions and checks against actual output IDs. Update the existing partial-fork expectation and retain malformed metadata and source-immutability coverage. Thanks to @tonydzi for the runningTurnSends report and @xg-gh-25 for the partial-fork/integrity suggestions in anthropics#1419. Compared with @somuai's anthropics#1428 to keep the overlapping fixes on one reviewable path. Developed with Codex assistance.
This was referenced Oct 28, 2026
A fork cut at a compact boundary could not keep that boundary's preserved blocks, because their anchor follows it, and resuming such a fork lost the earlier conversation (anthropics#1419). End the fork just before the boundary instead.
|
Hi @salma2vec, following up on our coordination in #1428. Could you add the Git co-authorship trailer to the bottom of the PR description? Adding it directly to the PR body ensures GitHub automatically populates the co-author attribution trailer in the squash-and-merge commit message when maintainers land the PR. Thank you! |
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1419.
Forking gives transcript records new UUIDs while compaction metadata still points to the source IDs. This changes the shared disk/store fork builder so copied messages and their known compaction references use the same mapping.
preservedSegment.headUuid/tailUuid/anchorUuid,preservedMessages.anchorUuid/uuids/allUuids, andrunningTurnSends.openerUuid/uuids/summarisedOnly.Retains the original parameterized disk/store, segment/list/both, partial-fork, malformed-metadata, and source-preservation coverage. Adds 56 cases across both public APIs and both AnyIO backends, with schema-aware assertions against the IDs actually emitted. These assertions are test safeguards, not runtime rejection or automatic discovery of future metadata fields.
Validation on main
2d485201617258867dd0f74b9e7307056f5938feplus this branch (Python 3.12, MCP 2.3.0):tests/suite: 1,701 passed, 6 skipped. The earlier timing assertion failure did not recur; no timing code or tests changed.git diff --check: pass.Update for the boundary cutoff (
e70a802, Python 3.12):tests/suite: 1,713 passed, 6 skipped. The three new boundary-cut tests (both APIs, both AnyIO backends) fail on the previous head and pass now. The existing store partial-fork test now expects the fork to stop before the boundary.The new evidence is synthetic public-API testing and local CLI code inspection. No end-to-end CLI/model resume was run; existing malformed or incomplete source metadata is not repaired.
Thanks to @tonydzi for the release reproduction and running-turn field report, @xg-gh-25 for the partial-fork/integrity suggestions, and @somuai for the overlapping implementation in #1428. This retains #1420's boundary-scoped helper and broader regression coverage; the follow-up can move to whichever PR maintainers select so only one implementation lands.
Developed with Codex assistance.
Co-authored-by: Soumyajit Ghosh [email protected]