fix(transform schema): support enums#1275
Merged
RobertCraigie merged 1 commit intonextfrom Mar 20, 2026
Merged
Conversation
|
|
||
| enum = json_schema.pop("enum", None) | ||
| if is_list(enum): | ||
| strict_schema['enum'] = enum |
Collaborator
There was a problem hiding this comment.
q: Can there be enum values that require transformation, or are they always just primitive values?
There was a problem hiding this comment.
I think enums can only contain literals in JSONSchema so no further translation necessary. The server actually doesn't support enum compilation beyond regular types (numbers, strings, books) so object literals will still fail but there's no way to transform that anyways.
Collaborator
Author
There was a problem hiding this comment.
Yeah in our codegen we only support primitive enums as well
karpetrosyan
approved these changes
Mar 20, 2026
Merged
alexlitinsky
pushed a commit
to alexlitinsky/claude-builders-bounty
that referenced
this pull request
Mar 28, 2026
…on (closes claude-builders-bounty#4) - agents/pr-reviewer/claude_review.py: CLI tool (--pr URL, --post-comment, --dry-run) - Uses Anthropic SDK (ANTHROPIC_API_KEY) or falls back to claude CLI subprocess - Fetches diff + metadata via gh CLI; skips generated/binary files; truncates large diffs - Structured Markdown output: Summary / Risks / Suggestions / Verdict sections - Confidence scoring (High/Medium/Low) based on diff size, test coverage, security files - Exit codes 0/1/2 for LOW/MEDIUM/HIGH risk — usable as CI gates - Per-repo config via .claude-review.yml - .github/workflows/pr-review.yml: GitHub Action that triggers on PR open/sync - examples/: actual outputs from cli/cli#100 and anthropics/anthropic-sdk-python#1275 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1208