Skip to content

feat: replace ezspawn with tinyexec#12

Merged
antfu merged 1 commit intoantfu-collective:mainfrom
benmccann:tinyexec
Aug 12, 2024
Merged

feat: replace ezspawn with tinyexec#12
antfu merged 1 commit intoantfu-collective:mainfrom
benmccann:tinyexec

Conversation

@benmccann
Copy link
Copy Markdown
Contributor

@benmccann benmccann commented Aug 7, 2024

Description

https://npmgraph.js.org/?q=@jsdevtools/ez-spawn - 9 dependencies
https://npmgraph.js.org/?q=tinyexec - 0 dependencies

@jsdevtools/ez-spawn also has not been updated in 4 years

Linked Issues

See #11 (comment)

Additional context

vitest would like to switch to tinyexec, but they use this library so are waiting for it to be switched first so that they can keep dependencies in sync

@antfu antfu changed the title chore: replace ezspawn with tinyexec feat: replace ezspawn with tinyexec Aug 12, 2024
@antfu antfu merged commit 8580e01 into antfu-collective:main Aug 12, 2024
@benmccann benmccann deleted the tinyexec branch August 12, 2024 14:43
@thetutlage
Copy link
Copy Markdown

This change resulted in a breaking change for us. Because tinyexec has a default timeout of 4000 milliseconds and most of the packages aren't installable in that time frame. tinylibs/tinyexec#29

antfu added a commit that referenced this pull request Aug 15, 2024
This reverts commit 8580e01.
@thetutlage
Copy link
Copy Markdown

Thanks for the revert @antfu. Appreciate it 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants