Skip to content

"Other" modules as categorized as CJS by default #124

@TheAlexLichter

Description

@TheAlexLichter

Describe the bug

As native bindings are more and more popular, they show up in module graphs. But in https://node-modules.dev/ they are listed as CJS while not being CJS.

I wonder if it should get another label (like "binary") so it is less confusing, or even count as ESM by default

Reproduction

https://node-modules.dev/#install=@oxc-parser/binding-linux-x64-gnu

System Info

not needed

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions