Skip to content

Add ghostify function#1

Merged
antalsz merged 3 commits intofix-ghost-locations-for-modular-extensionsfrom
add-ghostify-function
May 3, 2023
Merged

Add ghostify function#1
antalsz merged 3 commits intofix-ghost-locations-for-modular-extensionsfrom
add-ghostify-function

Conversation

@antalsz
Copy link
Owner

@antalsz antalsz commented May 3, 2023

Add Location.ghostify, which makes locations ghost

Copy link

@goldfirere goldfirere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@antalsz antalsz merged commit d93dcb5 into fix-ghost-locations-for-modular-extensions May 3, 2023
antalsz added a commit that referenced this pull request May 3, 2023
antalsz added a commit that referenced this pull request May 4, 2023
* Add `Location.ghostify`

* Update the parser's `make_ghost` to save an allocation in some cases

* Promote parser.ml
antalsz added a commit that referenced this pull request May 5, 2023
* Fix ghost locations in modular extension AST nodes

* Add missing ghostification

Thank you, Carl!

* Comment update about ghostiness (+ word-wrapping)

* Add ghostify function (#1)

* Add `Location.ghostify`

* Update the parser's `make_ghost` to save an allocation in some cases

* Promote parser.ml

* Mark the inner mutable arrays for iarrays as ghost

* Add comment about ghostification for comprehensions

* Explain that ppxlib is where the ghostiness requirement is enforced

* Use `Ast_helper.default_loc` to default the generated locations

* Restore propagating the location, now via `Ast_helper.default_loc`

* Drop obsolete comment

* Rewrite advisory comment about locations
antalsz added a commit that referenced this pull request May 31, 2023
antalsz added a commit that referenced this pull request May 31, 2023
antalsz added a commit that referenced this pull request Jun 5, 2023
antalsz added a commit that referenced this pull request Jun 12, 2023
* Parse `#0`, `-#1`, `oxcaml#2.7`, and `-oxcaml#3.1`, treating them as boxed

* Fix parsing of unsuffixed unboxed int literals

* Rewrite CR comment

* Update comment

* promote-menhir

* Unboxed literal tests

* Adjust error for unsuffixed unboxed integers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants