Skip to content

fix(locale): fill remaining DatePicker placeholders and Carousel labels - #59351

Merged
meet-student merged 2 commits into
ant-design:masterfrom
shoutoutuoadi325:fix/locale-fill-remaining-locales
Sep 22, 2026
Merged

meet-student merged 2 commits into
ant-design:masterfrom
shoutoutuoadi325:fix/locale-fill-remaining-locales

Conversation

@shoutoutuoadi325

@shoutoutuoadi325 shoutoutuoadi325 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

Follow-up to #59219 and #59218, same scripted diff of components/locale/*.ts against en_US. No related issue.

💡 Background and Solution

#59219 listed a set of locales it deliberately skipped because the wording could not be vouched for at the time, and #59218 missed 19 locale files for the Carousel arrow labels. This PR covers all of the leftovers, 42 files / 28 locales:

  • Full 8-key placeholder set for et_EE, eu_ES, hy_AM (its picker locale lives inline in components/locale/hy_AM.ts, and its timePickerLocale was also missing rangePlaceholder), is_IS, kmr_IQ (its alias ku_IQ re-exports these files), lv_LV, mk_MK, mn_MN, sl_SI.
  • rangeQuarterPlaceholder for bn_BD, ga_IE, ka_GE, kk_KZ, km_KH, ml_IN, ur_PK, uz_UZ, derived from each file's own quarterPlaceholder / rangeYearPlaceholder wording.
  • yearPlaceholder for ta_IN.
  • Carousel prevSlide / nextSlide for az_AZ, bn_BD, by_BY, eu_ES, ga_IE, hy_AM, is_IS, ka_GE, kk_KZ, km_KH, kmr_IQ, kn_IN, ku_IQ, ml_IN, mk_MK, mn_MN, mr_IN, my_MM, ne_NP, si_LK, sq_AL, ta_IN, tk_TK, ur_PK, uz_UZ.

Without these, picker="year" | "quarter" | "month" | "week" and the matching RangePickers fall back to the English placeholder in those locales, and the default Carousel arrows render without an aria-label.

Keys not consumed at runtime (weekSelect, dayFormat / cellMeridiemFormat defaults, Pagination.page_size, jump_to_confirm) are left alone, same as #59219.

Verified locally: npm run tsc (no new errors), eslint, biome lint and prettier --check on the touched files; rendered <DatePicker picker="year" /> under et_EE / is_IS, <RangePicker picker="quarter" /> under lv_LV and <Carousel arrows> under az_AZ / ku_IQ / sq_AL to confirm the new strings reach the DOM. The locale snapshot suites show pre-existing popup style diffs on a clean checkout in my environment (unpinned @rc-component resolution), so no snapshots were regenerated.

📝 Change Log

Language Changelog
🇺🇸 English Fixed missing locale entries: DatePicker and TimePicker placeholders for 19 locales (9 with the full set, including et_EE, is_IS, kmr_IQ, lv_LV, sl_SI) and Carousel arrow aria-labels for 25 locales.
🇨🇳 Chinese 补全缺失的多语言文案:19 个语言的 DatePicker / TimePicker 占位符(其中 9 个补齐全部键,含 et_EE、is_IS、kmr_IQ、lv_LV、sl_SI),以及 25 个语言的 Carousel 箭头 aria-label。

Copilot AI lite review requested due to automatic review settings September 21, 2026 09:13
@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Preview is ready

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

👁 Visual Regression Report for PR #59351 Passed ✅

🎯 Target branch: master (8a236ac)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

📖 中文报告

👁 PR #59351 视觉回归报告 通过 ✅

🎯 目标分支: master (8a236ac)

🎊 恭喜!未发现视觉回归差异。

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: a4a388fc-2da8-48bb-a3fe-a29f59d69be7

📥 Commits

Reviewing files that changed from the base of the PR and between 696835a and b25f8c6.

📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Summary

Summary by CodeRabbit

  • 新功能
    • 为更多语言新增轮播组件“上一张”和“下一张”按钮的本地化文本。
    • 为多种语言补充日期选择器的年份、季度、月份、周及范围选择占位提示。
    • 部分语言新增季度范围或年份选择占位文本。
    • 亚美尼亚语补充时间范围选择占位提示。

Walkthrough

本次变更为多种语言包补充日期选择器占位符、时间选择器范围占位符和 Carousel 轮播导航标签。size-limit 的构建产物上限从 530 KiB 调整为 531 KiB。

Changes

本地化配置更新

Layer / File(s) Summary
日期选择器占位符
components/date-picker/locale/*.ts
多个语言包新增年份、季度、月份、星期的单值和范围占位符。部分语言包仅新增季度范围或年份占位符。
轮播导航标签与体积限制
components/locale/*.ts, package.json
多个语言包新增 Carousel 配置,并提供 prevSlide 与 nextSlide 翻译。antd-with-locales.min.js 的体积上限从 530 KiB 提高至 531 KiB。
亚美尼亚语组件配置
components/locale/hy_AM.ts
亚美尼亚语配置新增日期选择器占位符、时间选择器范围占位符和 Carousel 导航标签。

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b25f8

This PR adds localized picker placeholders and Carousel navigation labels across supported locales. No actionable production risk remains evidenced, so it is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了本次变更:补全 DatePicker 占位符并新增 Carousel 标签。内容与主要改动一致,表述简洁明确。
Description check ✅ Passed 描述详细说明了 DatePicker、TimePicker 和 Carousel 本地化条目的补全范围、目的、验证结果及相关 PR。内容与变更集直接相关。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

小兔添上多语言提示,
年月季度各有文字。
轮播前后标签清晰,
亚美尼亚配置齐整,
体积边界也同步更新,
耳朵一竖,变更完成。

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from li-jia-nan September 21, 2026 09:15
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 6.89kB (0.21%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.24MB 6.89kB (0.21%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js 6.89kB 1.81MB 0.38%

Files in antd-with-locales.min.js:

  • ./components/locale/ku_IQ.ts → Total Size: 4.54kB

  • ./components/locale/hy_AM.ts → Total Size: 7.72kB

  • ./components/locale/kmr_IQ.ts → Total Size: 4.4kB

@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
More templates

npm i https://pkg.pr.new/antd@59351

commit: b25f8c6

@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8a236ac) to head (b25f8c6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #59351   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          834       834           
  Lines        16034     16034           
  Branches      4210      4210           
=========================================
  Hits         16034     16034           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meet-student meet-student left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文

LGTM。补的是缺失的 DatePicker placeholder 和 Carousel 文案,看起来是按语言翻译的,不是英文粘贴。antd-with-locales 体积上限 +1KiB 可以接受。

English

LGTM. Fills missing DatePicker placeholders and Carousel labels with real translations, not English copy-paste. The +1KiB antd-with-locales limit bump is reasonable.

@meet-student
meet-student merged commit a547175 into ant-design:master Sep 22, 2026
42 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

钉钉社区群二维码

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants