Repository navigation
fix(locale): fill remaining DatePicker placeholders and Carousel labels - #59351
meet-student merged 2 commits into
Conversation
|
|
👁 Visual Regression Report for PR #59351 Passed ✅
🎊 Congrats! No visual-regression diff found.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough本次变更为多种语言包补充日期选择器占位符、时间选择器范围占位符和 Carousel 轮播导航标签。 Changes本地化配置更新
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This PR adds localized picker placeholders and Carousel navigation labels across supported locales. No actionable production risk remains evidenced, so it is mergeable with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 小兔添上多语言提示, Comment |
Bundle ReportChanges will increase total bundle size by 6.89kB (0.21%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
|
More templates
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 834 834
Lines 16034 16034
Branches 4210 4210
=========================================
Hits 16034 16034 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
meet-student
left a comment
There was a problem hiding this comment.
中文
LGTM。补的是缺失的 DatePicker placeholder 和 Carousel 文案,看起来是按语言翻译的,不是英文粘贴。antd-with-locales 体积上限 +1KiB 可以接受。
English
LGTM. Fills missing DatePicker placeholders and Carousel labels with real translations, not English copy-paste. The +1KiB antd-with-locales limit bump is reasonable.



中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
Follow-up to #59219 and #59218, same scripted diff of
components/locale/*.tsagainsten_US. No related issue.💡 Background and Solution
#59219 listed a set of locales it deliberately skipped because the wording could not be vouched for at the time, and #59218 missed 19 locale files for the
Carouselarrow labels. This PR covers all of the leftovers, 42 files / 28 locales:et_EE,eu_ES,hy_AM(its picker locale lives inline incomponents/locale/hy_AM.ts, and itstimePickerLocalewas also missingrangePlaceholder),is_IS,kmr_IQ(its aliasku_IQre-exports these files),lv_LV,mk_MK,mn_MN,sl_SI.rangeQuarterPlaceholderforbn_BD,ga_IE,ka_GE,kk_KZ,km_KH,ml_IN,ur_PK,uz_UZ, derived from each file's ownquarterPlaceholder/rangeYearPlaceholderwording.yearPlaceholderforta_IN.CarouselprevSlide/nextSlideforaz_AZ,bn_BD,by_BY,eu_ES,ga_IE,hy_AM,is_IS,ka_GE,kk_KZ,km_KH,kmr_IQ,kn_IN,ku_IQ,ml_IN,mk_MK,mn_MN,mr_IN,my_MM,ne_NP,si_LK,sq_AL,ta_IN,tk_TK,ur_PK,uz_UZ.Without these,
picker="year" | "quarter" | "month" | "week"and the matchingRangePickers fall back to the English placeholder in those locales, and the default Carousel arrows render without anaria-label.Keys not consumed at runtime (
weekSelect,dayFormat/cellMeridiemFormatdefaults,Pagination.page_size,jump_to_confirm) are left alone, same as #59219.Verified locally:
npm run tsc(no new errors),eslint,biome lintandprettier --checkon the touched files; rendered<DatePicker picker="year" />underet_EE/is_IS,<RangePicker picker="quarter" />underlv_LVand<Carousel arrows>underaz_AZ/ku_IQ/sq_ALto confirm the new strings reach the DOM. The locale snapshot suites show pre-existing popup style diffs on a clean checkout in my environment (unpinned@rc-componentresolution), so no snapshots were regenerated.📝 Change Log
et_EE,is_IS,kmr_IQ,lv_LV,sl_SI) and Carousel arrowaria-labels for 25 locales.et_EE、is_IS、kmr_IQ、lv_LV、sl_SI),以及 25 个语言的 Carousel 箭头aria-label。