fix(ColorPicker): support locale for clear button aria-label by dogledogle · Pull Request #59206 · ant-design/ant-design

dogledogle · 2026-09-04T05:44:33Z

🤔 这个变动的性质是？

⌨️ 无障碍改进

🔗 相关 Issue

N/A

💡 需求背景和解决方案

ColorPicker 的清除按钮 aria-label 此前硬编码为英文 "Clear color"（ColorClear.tsx），导致任何语言下读屏器都播报英文。同目录的 ColorTrigger.tsx、ColorPresets.tsx 均已通过 useLocale('ColorPicker') 获取文案，仅此处遗漏。

解决方案：

ColorClear.tsx 改用 useLocale('ColorPicker') 读取 locale.clear 作为 aria-label（触发器与面板两处清除按钮同时修复）；
Locale 类型的 ColorPicker 段新增必填键 clear；
为全部语言文件补充 clear 翻译；
新增测试：zh_CN 下清除按钮 aria-label 应为 清除颜色。

📝 更新日志

语言	更新描述
🇺🇸 英文	🐞 Fix ColorPicker clear button `aria-label` not following the current locale.
🇨🇳 中文	🐞 修复 ColorPicker 清除按钮 `aria-label` 未跟随当前语言的问题。

bolt-new-by-stackblitz · 2026-09-04T05:44:35Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2026-09-04T05:44:40Z

github-actions · 2026-09-04T05:44:41Z

👁 Visual Regression Report for PR #59206 Passed ✅

🎯 Target branch: feature (d7e65da)
⚠️ Baseline may be stale: no snapshot for the PR's base commit was found, so an older branch snapshot was used. Some diffs below may come from changes already merged into feature rather than this PR.
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

📖 中文报告

👁 PR #59206 视觉回归报告通过 ✅

🎯 目标分支: feature (d7e65da)
⚠️ 基线可能已过期: 未找到该 PR 基准提交对应的快照,因此回退使用了较旧的分支快照。下方部分差异可能来自已合并到 feature 的改动,而非本 PR。

🎊 恭喜!未发现视觉回归差异。

coderabbitai · 2026-09-04T05:44:42Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 32ae2047-6f52-4311-80f2-c71a218813ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-04T05:48:04Z

More templates

npm i https://pkg.pr.new/antd@59206

commit: 16a861f

codecov · 2026-09-04T05:48:11Z

Bundle Report

Changes will increase total bundle size by 2.08kB (0.06%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.26MB	2.08kB (0.06%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	2.02kB	1.83MB	0.11%
`antd.min.js`	51 bytes	1.43MB	0.0%

Files in antd-with-locales.min.js:

./components/locale/en_US.ts → Total Size: 4.33kB
./components/locale/hy_AM.ts → Total Size: 7.25kB

Files in antd.min.js:

./components/locale/en_US.ts → Total Size: 4.33kB

codecov · 2026-09-04T05:59:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d7e65da) to head (16a861f).
⚠️ Report is 12 commits behind head on feature.

Additional details and impacted files

@@            Coverage Diff            @@
##           feature    #59206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          834       834           
  Lines        16136     16138    +2     
  Branches      4263      4264    +1     
=========================================
+ Hits         16136     16138    +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yoyo837 · 2026-09-04T05:59:56Z

这个是我之前让贡献者不要添加其他语言让Native Speaker来加。若Owner持不同看法，就忽略我。

dogledogle · 2026-09-04T07:00:55Z

好的，我是看到 #58978 说可以加，所以补了这个

yoyo837 · 2026-09-04T07:14:45Z

好的，我是看到 #58978 说可以加，所以补了这个

可以到群里让大佬定个调，然后大家一致处理。

dogledogle · 2026-09-10T05:27:36Z

yoyo837 · 2026-09-21T00:54:35Z

冲突啦

Signed-off-by: 多格 <[email protected]>

dogledogle · 2026-09-21T04:38:34Z

冲突啦

改好了

meet-student

中文

LGTM。Clear 按钮 aria-label 走 locale.clear，类型和各语言都补了。

注意：#59130 也改了 ColorClear.tsx，合入时会冲突，需要错开或先 rebase。

English

LGTM. The clear button aria-label now uses locale.clear, with the type and locales updated.

Note: #59130 also edits ColorClear.tsx, so these will conflict and need to be sequenced.

fix(ColorPicker): support locale for clear button aria-label

d67cdc0

dogledogle force-pushed the fix/color-picker-clear-locale branch from 0fdb94b to d67cdc0 Compare September 10, 2026 05:25

thinkasany requested a review from yoyo837 September 12, 2026 08:54

thinkasany previously approved these changes Sep 12, 2026

View reviewed changes

Merge branch 'feature' into fix/color-picker-clear-locale

16a861f

Signed-off-by: 多格 <[email protected]>

dogledogle dismissed thinkasany’s stale review via 16a861f September 21, 2026 04:17

meet-student approved these changes Sep 22, 2026

View reviewed changes

meet-student mentioned this pull request Sep 22, 2026

fix(ColorPicker): make default trigger keyboard accessible #59130

Open

2 of 4 tasks

Conversation

dogledogle commented Sep 4, 2026

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

Uh oh!

bolt-new-by-stackblitz Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #59206 Passed ✅

👁 PR #59206 视觉回归报告 通过 ✅

Uh oh!

coderabbitai Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

pkg-pr-new Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yoyo837 commented Sep 4, 2026

Uh oh!

dogledogle commented Sep 4, 2026

Uh oh!

yoyo837 commented Sep 4, 2026

Uh oh!

dogledogle commented Sep 10, 2026

Uh oh!

yoyo837 commented Sep 21, 2026

Uh oh!

dogledogle commented Sep 21, 2026

Uh oh!

meet-student left a comment

Choose a reason for hiding this comment

中文

English

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Sep 4, 2026 •

edited

Loading

github-actions Bot commented Sep 4, 2026 •

edited

Loading

👁 PR #59206 视觉回归报告通过 ✅

coderabbitai Bot commented Sep 4, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 4, 2026 •

edited

Loading

codecov Bot commented Sep 4, 2026 •

edited

Loading

codecov Bot commented Sep 4, 2026 •

edited

Loading