Repository navigation
fix(DatePicker): use German date formats - #59151
Conversation
|
|
👁 Visual Regression Report for PR #59151 Passed ✅
🎊 Congrats! No visual-regression diff found.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough本次变更为德语 Changes德语日期格式
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to German DatePicker inputs now render dates as DD.MM.YYYY and date-times in 24-hour format. The targeted behavior is covered, with no remaining current-head merge risk identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 71 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
|
CI root-cause update: the six Tooltip failures are reproducible as an nwsapi 2.2.25 regression, not a DatePicker change. PR #59150 independently failed the same two shards and the same six tests after that release. On this PR exact head, the affected files fail 6/55 with 2.2.25 and pass 55/55 (5 snapshots) with 2.2.24 or the focused guard restored. I reported the upstream regression at dperini/nwsapi#168 and submitted the fix at dperini/nwsapi#169. No DatePicker code change is needed for this failure; the check should be retried after the dependency is fixed or pinned. AI assistance disclosure: Codex helped trace the dependency and run the A/B verification; I reviewed and reproduced the results locally. |
|
CI failed. |
|
Confirmed. The failed shards are the six Tooltip tests described above. I checked the newly published nwsapi 2.2.26 before rerunning: a clean jsdom 26.1.0 install still throws the same TypeError for the compound selector and root :has(~ p), so rerunning now would remain deterministically red. The upstream fix is rebased onto current nwsapi master at signed/Verified head e33a8ae: dperini/nwsapi#169. I will rerun this PR after a fixed upstream release rather than add an unrelated DatePicker dependency pin. AI assistance disclosure: Codex helped run the clean-install 2.2.26 probe; I verified the result locally. |
47e2d80 to
238ec0f
Compare
|
Thanks for flagging this. I rebased the PR onto current The previous failures were six Tooltip tests failing inside
I will leave the new CI run to complete without further retriggers. AI assistance was used to inspect the failed-job logs and prepare the rebase/validation summary; the exact diff and commands were verified locally. |
|
Please use the official PR template and complete the bilingual Change Log section; otherwise, release changelog collection will be affected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 834 834
Lines 15991 15991
Branches 4202 4202
=========================================
Hits 15991 15991 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the guidance. I updated the PR description to the official template and completed both the English and Chinese Change Log entries. The existing AI assistance disclosure remains included in the description. |
Sync ant-design/ant-design#59151: add fieldDateFormat and fieldDateTimeFormat to the de_DE picker locale so DatePicker renders DD.MM.YYYY under the German ConfigProvider locale.


🤔 This is a ...
🔗 Related Issues
Closes #59149
💡 Background and Solution
The German DatePicker locale inherited the generic
YYYY-MM-DDfallback, so a value such as January 1, 2000 was displayed as2000-01-01instead of the standard German01.01.2000. The date-time fallback had the same ordering issue.This change defines the German date and 24-hour date-time formats already used by the repository's Day.js German locale. It also adds focused coverage through the public
ConfigProviderlocale path for both DatePicker and DatePicker withshowTime, and updates the generated locale snapshots.Validation:
01.01.2000, received2000-01-01git diff --checkpassed📝 Change Log
DD.MM.YYYY) and date-time (DD.MM.YYYY HH:mm:ss) formats with the German locale.DD.MM.YYYY)和日期时间(DD.MM.YYYY HH:mm:ss)格式。AI assistance disclosure: Codex was used to trace the locale merge path, audit overlapping open PR files, reproduce the regression, run validation, investigate the unrelated CI dependency failure, and draft this report. I verified the final diff, commands, and results.